remove comments

This commit is contained in:
genghaozhe
2024-05-20 05:15:51 +00:00
parent 7416e4943b
commit 5c6c5d6be3
6 changed files with 148 additions and 9 deletions

View File

@@ -37,18 +37,16 @@ class GeminiZeROHook(ColoParamOpHook):
# transfer state
for p in params:
# TODO(haze188): check状态转换
self._chunk_manager.trans_tensor_state(p, TensorState.COMPUTE)
self._gemini_manager.sample_overall_data()
# evit chunks, aware of async fetched
# TODO(haze188): 可能我们prefetch的又被淘汰掉, check一下
# TODO: check if prefetched chunks will be evicted
self._gemini_manager.adjust_layout(
all_chunks, record_anyway=self._gemini_manager.placement_policy.max_prefetch > 0
)
# fetch the rest synchronously
# TODO(haze188): 1. 先prefetch还是先fetchprefetch是异步fetch是同步
for chunk in chunks_fetch_sync:
self._chunk_manager.access_chunk(chunk)

View File

@@ -154,7 +154,6 @@ class GeminiManager:
def _record_warmup_chunks_order(self, chunks: Tuple[Chunk, ...], record_anyway: bool = False) -> None:
self._compute_idx += 1
# TODO(haze188): _compute_list 记录块的访问顺序
if self._warmup and (self._placement_policy.need_mem_stats or record_anyway):
self._compute_list.append(chunks)