From 37660eec41d977beabcc1aa4a54e2b736960c7b7 Mon Sep 17 00:00:00 2001
From: yyhhyyyyyy <95077259+yyhhyyyyyy@users.noreply.github.com>
Date: Tue, 11 Mar 2025 17:15:40 +0800
Subject: [PATCH] workflow(pylint): fix pylint workflow

---
 .github/workflows/pylint.yml                   | 18 ++++++++----------
 Makefile                                       | 17 +++++++++++------
 .../storage/vector_store/milvus_store.py       |  8 +++-----
 pyproject.toml                                 |  2 +-
 4 files changed, 23 insertions(+), 22 deletions(-)

diff --git a/.github/workflows/pylint.yml b/.github/workflows/pylint.yml
index 801c03e4f..071f24243 100644
--- a/.github/workflows/pylint.yml
+++ b/.github/workflows/pylint.yml
@@ -14,18 +14,16 @@ concurrency:
 jobs:
   build:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.10", "3.11"]
     steps:
     - uses: actions/checkout@v3
-    - name: Set up Python ${{ matrix.python-version }}
-      uses: actions/setup-python@v3
-      with:
-        python-version: ${{ matrix.python-version }}
+    - name: Install uv
+      run: curl -LsSf https://astral.sh/uv/install.sh | sh
     - name: Install dependencies and setup environment
-      run: make setup
+      run: |
+        uv -V
+        make setup
     - name: Check Python code style
       run: make fmt-check
-    - name: Check Python code type
-      run: make mypy
+    # TODO: Add mypy check
+    # - name: Check Python code type
+    #   run: make mypy
diff --git a/Makefile b/Makefile
index 43fe72dd4..51399cf26 100644
--- a/Makefile
+++ b/Makefile
@@ -16,17 +16,21 @@ $(VENV)/bin/activate: $(VENV)/.venv-timestamp
 
 $(VENV)/.venv-timestamp: uv.lock
 	# Create new virtual environment if setup.py has changed
-	#python3 -m venv $(VENV)
-	uv venv --python 3.10 $(VENV)
+	uv venv --python 3.11 $(VENV)
 	uv pip install --prefix $(VENV) ruff
+	uv pip install --prefix $(VENV) mypy
 	touch $(VENV)/.venv-timestamp
 
 testenv: $(VENV)/.testenv
 
 $(VENV)/.testenv: $(VENV)/bin/activate
-	# $(VENV_BIN)/pip install -e ".[framework]"
-	# the openai optional dependency is include framework and rag dependencies
-	$(VENV_BIN)/pip install -e ".[openai]"
+	uv sync --all-packages \
+		--extra "base" \
+		--extra "proxy_openai" \
+		--extra "rag" \
+		--extra "storage_chromadb" \
+		--extra "dbgpts" \
+		--link-mode=copy
 	touch $(VENV)/.testenv
 
 
@@ -75,7 +79,8 @@ test-doc: $(VENV)/.testenv ## Run doctests
 .PHONY: mypy
 mypy: $(VENV)/.testenv ## Run mypy checks
 	# https://github.com/python/mypy
-	$(VENV_BIN)/mypy --config-file .mypy.ini dbgpt/rag/ dbgpt/datasource/ dbgpt/client/ dbgpt/agent/ dbgpt/vis/ dbgpt/experimental/
+	$(VENV_BIN)/mypy --config-file .mypy.ini --ignore-missing-imports packages/dbgpt-core/
+	# $(VENV_BIN)/mypy --config-file .mypy.ini dbgpt/rag/ dbgpt/datasource/ dbgpt/client/ dbgpt/agent/ dbgpt/vis/ dbgpt/experimental/
 	# rag depends on core and storage, so we not need to check it again.
 	# $(VENV_BIN)/mypy --config-file .mypy.ini dbgpt/storage/
 	# $(VENV_BIN)/mypy --config-file .mypy.ini dbgpt/core/
diff --git a/packages/dbgpt-ext/src/dbgpt_ext/storage/vector_store/milvus_store.py b/packages/dbgpt-ext/src/dbgpt_ext/storage/vector_store/milvus_store.py
index bc8c25cb9..81e54ed19 100644
--- a/packages/dbgpt-ext/src/dbgpt_ext/storage/vector_store/milvus_store.py
+++ b/packages/dbgpt-ext/src/dbgpt_ext/storage/vector_store/milvus_store.py
@@ -641,13 +641,11 @@ class MilvusStore(VectorStoreBase):
         return metadata_filter_expr
 
     def truncate(self):
-        """Truncate milvus collection.
-        """
+        """Truncate milvus collection."""
         logger.info(f"begin truncate milvus collection:{self.collection_name}")
         from pymilvus import utility
+
         if utility.has_collection(self.collection_name):
             utility.drop_collection(self.collection_name)
 
-        logger.info(
-            f"truncate milvus collection {self.collection_name} success"
-        )
\ No newline at end of file
+        logger.info(f"truncate milvus collection {self.collection_name} success")
diff --git a/pyproject.toml b/pyproject.toml
index c8f3d4684..74878e886 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -69,6 +69,6 @@ line-ending = "auto"
 # Enable: eror check, import order
 select = ["E", "F", "I"]
 
-[tool.ruff.isort]
+[tool.ruff.lint.isort]
 # Specify the local modules (first-party)
 known-first-party = ["dbgpt", "dbgpt_acc_auto", "dbgpt_client", "dbgpt_ext", "dbgpt_serve", "dbgpt_app"]