mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2025-09-09 12:49:24 +00:00
hv: resolve the negative impacts to UOS MSI/MSI-X remapping
After enabling vPCI in hypervisor for vm0, UOS may not able be launched successfully. Consider this scenario (take MSI-X for example): - DM makes hypercall to hypervisor to do MSI-X remapping on behalf of UOS guests. - After the hypercall, VHM module in SOS kernel updates the physical MSI-X table with the physical Message Data/Addr. - These MMIO write requests are intercepted by hypervisor, which will call ptdev_msix_remap() to do MSI-S remapping. It may fail due to 2 possible reasons: 1) wrong target VM because: hypervisor thinks it's a VM0 MSI-X device but they have been registered as UOS guests through HC_SET_PTDEV_INTR_INFO hypercall. 2) wrong ptdev_msi_info->vmsi_data because: The virtual MSI-X table is supposed to hold virtual Message data/addr but the SOS VHM writes the physical ones to it. This patch resolves these problems by ignoring the HC_VM_PCI_MSIX_REMAP hypercall, so virtual and physical Message Data are the same from SOS' perspective and it won't mess up the virtual PCI device in HV. Also in HC_SET_PTDEV_INTR_INFO handler, vpci updates the target VM when the PCI devices are assigned to different VMs. The UOS' MSI/MSI-X remapping is triggered by hypervisor when SOS (either DM or VHM) updates the Message Data/Addr. Tracked-On: #1568 Signed-off-by: dongshen <dongsheng.x.zhang@intel.com> Signed-off-by: Zide Chen <zide.chen@intel.com> Acked-by: Anthony Xu <anthony.xu@intel.com>
This commit is contained in:
@@ -250,22 +250,6 @@ int32_t hcall_set_vm_memory_regions(struct vm *vm, uint64_t param);
|
||||
*/
|
||||
int32_t hcall_write_protect_page(struct vm *vm, uint16_t vmid, uint64_t wp_gpa);
|
||||
|
||||
/**
|
||||
* @brief remap PCI MSI interrupt
|
||||
*
|
||||
* Remap a PCI MSI interrupt from a VM's virtual vector to native vector.
|
||||
* The function will return -1 if the target VM does not exist.
|
||||
*
|
||||
* @param vm Pointer to VM data structure
|
||||
* @param vmid ID of the VM
|
||||
* @param param guest physical address. This gpa points to
|
||||
* struct acrn_vm_pci_msix_remap
|
||||
*
|
||||
* @pre Pointer vm shall point to VM0
|
||||
* @return 0 on success, non-zero on error.
|
||||
*/
|
||||
int32_t hcall_remap_pci_msix(struct vm *vm, uint16_t vmid, uint64_t param);
|
||||
|
||||
/**
|
||||
* @brief translate guest physical address to host physical address
|
||||
*
|
||||
|
Reference in New Issue
Block a user