github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-05 10:20:55 +00:00
Code Issues Projects Releases Wiki Activity

acrntrace: Set FLAG_CLEAR_BUF by default

Browse Source 
Normally, we care more about the current trace data than
buffered old data. So, this patch set FLAG_CLEAR_BUF by
default and adds one new option '-r' to unset the FLAG_CLEAR_BUF
if we want to capture the buffered old data.

---
  v1 -> v2:
  Add 'deprecated' mark to '-c' option

Tracked-On: #4175
Signed-off-by: Kaige Fu <kaige.fu@intel.com>
This commit is contained in:
Kaige Fu 2019-12-01 22:01:02 +00:00 committed by wenlingz
parent 9e9e1f61ad
commit 0bf03b411e
2 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
misc/tools/acrntrace/README.rst
View File

@ -23,7 +23,8 @@ Options:
-h print this message -h print this message
-i period specify polling interval in milliseconds [1-999] -i period specify polling interval in milliseconds [1-999]
-t max_time max time to capture trace data (in second) -t max_time max time to capture trace data (in second)
-c clear the buffered old data -c clear the buffered old data (deprecated)
-r capture the buffered old data instead of clearing it
-a cpu-set only capture the trace data on these configured cpu-set -a cpu-set only capture the trace data on these configured cpu-set
acrntrace_format.py acrntrace_format.py

15
misc/tools/acrntrace/acrntrace.c
View File

@ -30,10 +30,10 @@ static int exiting = 0;
/* for opt */ /* for opt */
static uint64_t period = 10000; static uint64_t period = 10000;
static const char optString[] = "i:hct:a:"; static const char optString[] = "i:hcrt:a:";
static const char dev_prefix[] = "acrn_trace_"; static const char dev_prefix[] = "acrn_trace_";
static uint32_t flags; static uint32_t flags = FLAG_CLEAR_BUF;
static char trace_file_dir[TRACE_FILE_DIR_LEN]; static char trace_file_dir[TRACE_FILE_DIR_LEN];
static reader_struct *reader; static reader_struct *reader;
@ -49,7 +49,8 @@ static void display_usage(void)
"\t-h: print this message\n" "\t-h: print this message\n"
"\t-i: period_in_ms: specify polling interval [1-999]\n" "\t-i: period_in_ms: specify polling interval [1-999]\n"
"\t-t: max time to capture trace data (in second)\n" "\t-t: max time to capture trace data (in second)\n"
"\t-c: clear the buffered old data\n" "\t-c: clear the buffered old data (deprecated)\n"
"\t-r: capture the buffered old data instead of clearing it\n"
"\t-a: cpu-set: only capture the trace data on these configured cpu-set\n"); "\t-a: cpu-set: only capture the trace data on these configured cpu-set\n");
} }
@ -117,8 +118,14 @@ static int parse_opt(int argc, char *argv[])
timeout = ret; timeout = ret;
pr_dbg("Capture trace data for at most %ds\n", ret); pr_dbg("Capture trace data for at most %ds\n", ret);
break; break;
/*
* We have set the FLAG_CLEAR_BUF by default.
* Here we just keep the -c for backward compatibility.
*/
case 'c': case 'c':
flags |= FLAG_CLEAR_BUF; break;
case 'r':
flags &= ~FLAG_CLEAR_BUF;
break; break;
case 'a': case 'a':
cpu_bitmask = numa_parse_cpustring_all(optarg); cpu_bitmask = numa_parse_cpustring_all(optarg);