github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-09 03:58:34 +00:00
Code Issues Projects Releases Wiki Activity

hv: mmu: invalidate cached translation information for guest

Browse Source 
Sometimes we need to invalidate cached translation information for guest
when change some bits in CR0/CR4 which related to paging. Here're two cases:
1. If there change some bits to enable/disable paging (mode) or access rights.
For CR0: PG/WP/CD/NW; For CR4: PGE/PSE/PAE/SMEP/SMAP/PKE
2. When guest using PAE paging, we should reload the PDPTE registers sometimes,
detail in SDM Vol 3 Chap 4.4.1 and Chap 4.11.1

Tracked-On: #1379
Signed-off-by: Li, Fei1 <fei1.li@intel.com>
This commit is contained in:
Li, Fei1 2018-09-29 14:31:41 +08:00 committed by wenlingz
parent 2b24b3780f
commit 1e084b08f2
1 changed files with 67 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
hypervisor/arch/x86/vmx.c
View File

@ -292,6 +292,18 @@ int vmx_wrmsr_pat(struct vcpu *vcpu, uint64_t value)
return 0; return 0;
} }
static void load_pdptrs(struct vcpu *vcpu)
{
uint64_t guest_cr3 = exec_vmread(VMX_GUEST_CR3);
/* TODO: check whether guest cr3 is valid */
uint64_t *guest_cr3_hva = (uint64_t *)gpa2hva(vcpu->vm, guest_cr3);
exec_vmwrite64(VMX_GUEST_PDPTE0_FULL, get_pgentry(guest_cr3_hva + 0UL));
exec_vmwrite64(VMX_GUEST_PDPTE1_FULL, get_pgentry(guest_cr3_hva + 1UL));
exec_vmwrite64(VMX_GUEST_PDPTE2_FULL, get_pgentry(guest_cr3_hva + 2UL));
exec_vmwrite64(VMX_GUEST_PDPTE3_FULL, get_pgentry(guest_cr3_hva + 3UL));
}
static bool is_cr0_write_valid(struct vcpu *vcpu, uint64_t cr0) static bool is_cr0_write_valid(struct vcpu *vcpu, uint64_t cr0)
{ {
/* Shouldn't set always off bit */ /* Shouldn't set always off bit */
@ -348,7 +360,8 @@ void vmx_write_cr0(struct vcpu *vcpu, uint64_t cr0)
{ {
uint64_t cr0_vmx; uint64_t cr0_vmx;
uint32_t entry_ctrls; uint32_t entry_ctrls;
bool paging_enabled = is_paging_enabled(vcpu); bool old_paging_enabled = is_paging_enabled(vcpu);
uint64_t cr0_changed_bits = vcpu_get_cr0(vcpu) ^ cr0;
if (!is_cr0_write_valid(vcpu, cr0)) { if (!is_cr0_write_valid(vcpu, cr0)) {
pr_dbg("Invalid cr0 write operation from guest"); pr_dbg("Invalid cr0 write operation from guest");
@ -360,37 +373,41 @@ void vmx_write_cr0(struct vcpu *vcpu, uint64_t cr0)
* When loading a control register, reserved bit should always set * When loading a control register, reserved bit should always set
* to the value previously read. * to the value previously read.
*/ */
cr0 = (cr0 & ~CR0_RESERVED_MASK) | cr0 &= ~CR0_RESERVED_MASK;
(vcpu_get_cr0(vcpu) & CR0_RESERVED_MASK);
if (((vcpu_get_efer(vcpu) & MSR_IA32_EFER_LME_BIT) != 0UL) && if (!old_paging_enabled && ((cr0 & CR0_PG) != 0UL)) {
!paging_enabled && ((cr0 & CR0_PG) != 0UL)) { if ((vcpu_get_efer(vcpu) & MSR_IA32_EFER_LME_BIT) != 0UL) {
/* Enable long mode */ /* Enable long mode */
pr_dbg("VMM: Enable long mode"); pr_dbg("VMM: Enable long mode");
entry_ctrls = exec_vmread32(VMX_ENTRY_CONTROLS); entry_ctrls = exec_vmread32(VMX_ENTRY_CONTROLS);
entry_ctrls |= VMX_ENTRY_CTLS_IA32E_MODE; entry_ctrls |= VMX_ENTRY_CTLS_IA32E_MODE;
exec_vmwrite32(VMX_ENTRY_CONTROLS, entry_ctrls); exec_vmwrite32(VMX_ENTRY_CONTROLS, entry_ctrls);
vcpu_set_efer(vcpu, vcpu_set_efer(vcpu,
vcpu_get_efer(vcpu) | MSR_IA32_EFER_LMA_BIT); vcpu_get_efer(vcpu) | MSR_IA32_EFER_LMA_BIT);
} else if (((vcpu_get_efer(vcpu) & MSR_IA32_EFER_LME_BIT) != 0UL) && } else if (is_pae(vcpu)) {
paging_enabled && ((cr0 & CR0_PG) == 0UL)){ /* enabled PAE from paging disabled */
/* Disable long mode */ load_pdptrs(vcpu);
pr_dbg("VMM: Disable long mode"); } else {
entry_ctrls = exec_vmread32(VMX_ENTRY_CONTROLS); }
entry_ctrls &= ~VMX_ENTRY_CTLS_IA32E_MODE; } else if (old_paging_enabled && ((cr0 & CR0_PG) == 0UL)) {
exec_vmwrite32(VMX_ENTRY_CONTROLS, entry_ctrls); if ((vcpu_get_efer(vcpu) & MSR_IA32_EFER_LME_BIT) != 0UL) {
/* Disable long mode */
pr_dbg("VMM: Disable long mode");
entry_ctrls = exec_vmread32(VMX_ENTRY_CONTROLS);
entry_ctrls &= ~VMX_ENTRY_CTLS_IA32E_MODE;
exec_vmwrite32(VMX_ENTRY_CONTROLS, entry_ctrls);
vcpu_set_efer(vcpu, vcpu_set_efer(vcpu,
vcpu_get_efer(vcpu) & ~MSR_IA32_EFER_LMA_BIT); vcpu_get_efer(vcpu) & ~MSR_IA32_EFER_LMA_BIT);
} else { } else {
/* CR0.PG unchanged. */ }
} }
/* If CR0.CD or CR0.NW get changed */ /* If CR0.CD or CR0.NW get cr0_changed_bits */
if (((vcpu_get_cr0(vcpu) ^ cr0) & (CR0_CD | CR0_NW)) != 0UL) { if ((cr0_changed_bits & (CR0_CD | CR0_NW)) != 0UL) {
/* No action if only CR0.NW is changed */ /* No action if only CR0.NW is cr0_changed_bits */
if (((vcpu_get_cr0(vcpu) ^ cr0) & CR0_CD) != 0UL) { if ((cr0_changed_bits & CR0_CD) != 0UL) {
if ((cr0 & CR0_CD) != 0UL) { if ((cr0 & CR0_CD) != 0UL) {
/* /*
* When the guest requests to set CR0.CD, we don't allow * When the guest requests to set CR0.CD, we don't allow
@ -409,6 +426,10 @@ void vmx_write_cr0(struct vcpu *vcpu, uint64_t cr0)
} }
} }
if ((cr0_changed_bits & (CR0_PG | CR0_WP)) != 0UL) {
vcpu_make_request(vcpu, ACRN_REQUEST_EPT_FLUSH);
}
/* CR0 has no always off bits, except the always on bits, and reserved /* CR0 has no always off bits, except the always on bits, and reserved
* bits, allow to set according to guest. * bits, allow to set according to guest.
*/ */
@ -426,7 +447,7 @@ void vmx_write_cr0(struct vcpu *vcpu, uint64_t cr0)
cr0, cr0_vmx); cr0, cr0_vmx);
} }
static bool is_cr4_write_valid(uint64_t cr4) static bool is_cr4_write_valid(struct vcpu *vcpu, uint64_t cr4)
{ {
/* Check if guest try to set fixed to 0 bits or reserved bits */ /* Check if guest try to set fixed to 0 bits or reserved bits */
if ((cr4 & cr4_always_off_mask) != 0U) if ((cr4 & cr4_always_off_mask) != 0U)
@ -440,6 +461,12 @@ static bool is_cr4_write_valid(uint64_t cr4)
if ((cr4 & CR4_PCIDE) != 0UL) if ((cr4 & CR4_PCIDE) != 0UL)
return false; return false;
if (is_long_mode(vcpu)) {
if ((cr4 & CR4_PAE) == 0UL) {
return false;
}
}
return true; return true;
} }
@ -481,13 +508,24 @@ static bool is_cr4_write_valid(uint64_t cr4)
void vmx_write_cr4(struct vcpu *vcpu, uint64_t cr4) void vmx_write_cr4(struct vcpu *vcpu, uint64_t cr4)
{ {
uint64_t cr4_vmx; uint64_t cr4_vmx;
uint64_t old_cr4 = vcpu_get_cr4(vcpu);
if (!is_cr4_write_valid(cr4)) { if (!is_cr4_write_valid(vcpu, cr4)) {
pr_dbg("Invalid cr4 write operation from guest"); pr_dbg("Invalid cr4 write operation from guest");
vcpu_inject_gp(vcpu, 0U); vcpu_inject_gp(vcpu, 0U);
return; return;
} }
if (((cr4 ^ old_cr4) & (CR4_PGE | CR4_PSE | CR4_PAE |
CR4_SMEP | CR4_SMAP | CR4_PKE)) != 0UL) {
if (((cr4 & CR4_PAE) != 0UL) && is_paging_enabled(vcpu) &&
(is_long_mode(vcpu))) {
load_pdptrs(vcpu);
}
vcpu_make_request(vcpu, ACRN_REQUEST_EPT_FLUSH);
}
/* Aways off bits and reserved bits has been filtered above */ /* Aways off bits and reserved bits has been filtered above */
cr4_vmx = cr4_always_on_mask | cr4; cr4_vmx = cr4_always_on_mask | cr4;
exec_vmwrite(VMX_GUEST_CR4, cr4_vmx & 0xFFFFFFFFUL); exec_vmwrite(VMX_GUEST_CR4, cr4_vmx & 0xFFFFFFFFUL);