github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-08 10:04:42 +00:00
Code Issues Projects Releases Wiki Activity

dm: use strncpy to replace strcpy

Browse Source 
Use strncpy instead of strcpy to avoid buf overflow.
Fix strncpy null-terminated issues.

Tracked-On: #3245
Signed-off-by: Tianhua Sun <tianhuax.s.sun@intel.com>
Acked-by: Anthony Xu <anthony.xu@intel.com>
This commit is contained in:
Tianhua Sun
2019-06-11 10:22:27 +08:00
committed by wenlingz
parent 0ea788b48e
commit 1e1244c36b
5 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
devicemodel/hw/pci/virtio/virtio_console.c
View File

@@ -625,7 +625,8 @@ virtio_console_accept_new_connection(int fd __attribute__((unused)),
memset(&addr, 0, sizeof(addr));
addr.sun_family = AF_UNIX;
strcpy(addr.sun_path, be->portpath);
strncpy(addr.sun_path, be->portpath, sizeof(addr.sun_path));
addr.sun_path[sizeof(addr.sun_path) - 1] = '\0';
len = sizeof(addr);
accepted_fd = accept(be->fd, (struct sockaddr *)&addr, &len);
@@ -728,7 +729,8 @@ virtio_console_config_backend(struct virtio_console_backend *be)
memset(&addr, 0, sizeof(addr));
addr.sun_family = AF_UNIX;
strcpy(addr.sun_path, be->portpath);
strncpy(addr.sun_path, be->portpath, sizeof(addr.sun_path));
addr.sun_path[sizeof(addr.sun_path) - 1] = '\0';
if (be->socket_type == NULL || !strcmp(be->socket_type,"server")) {
unlink(be->portpath);