From 1f20d5e7a0ed8dfb478bbaa4b0121ccb78101ce1 Mon Sep 17 00:00:00 2001
From: "Zhou, Wu" <wu.zhou@intel.com>
Date: Tue, 3 May 2022 14:51:52 +0800
Subject: [PATCH] config-tools: board_inspector deb appends kernel CMDLINE

Currently installing board_inspector deb would overwrite the grub
default kernel CMDLINE GRUB_CMDLINE_LINUX_DEFAULT. This could lose
some useful kernel args configured by user.

This patch is to change the 'overwrite' operation to 'append'.

Simply appending new CMDLINE to GRUB_CMDLINE_LINUX_DEFAULT could
not work. We need to remove duplicated args, and keep the args in
its origin order.

Tracked-On: #7402

Signed-off-by: Zhou, Wu <wu.zhou@intel.com>
---
 misc/packaging/acrn-board-inspector.postinst | 29 +++++++++++++++++++-
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/misc/packaging/acrn-board-inspector.postinst b/misc/packaging/acrn-board-inspector.postinst
index 15a587c69..35fe2c4d9 100644
--- a/misc/packaging/acrn-board-inspector.postinst
+++ b/misc/packaging/acrn-board-inspector.postinst
@@ -9,7 +9,34 @@ sed -i '/GRUB_DEFAULT/d' ${filename}
 sed -i '/GRUB_TIMEOUT/d' ${filename}
 sed -i '/GRUB_HIDDEN_TIMEOUT/d' ${filename}
 sed -i '/GRUB_CMDLINE_LINUX_DEFAULT/d' ${filename}
-sed -i '$a GRUB_CMDLINE_LINUX_DEFAULT="quiet splash iomem=relaxed intel_idle.max_cstate=0 intel_pstate=disable"' ${filename}
+
+#this is the kernel cmdline we are appending to the GRUB_CMDLINE_LINUX_DEFAULT
+add_cmdline="quiet splash iomem=relaxed intel_idle.max_cstate=0 intel_pstate=disable"
+
+origin_cmdline=`sed -n 's/GRUB_CMDLINE_LINUX_DEFAULT*=//'p ${filename} | xargs echo | sed -n 's/ /\n/g'p`
+add_cmdline=`echo ${add_cmdline} | sed -n 's/ /\n/g'p`
+
+#remove the duplicated args after appending, while keep the args in origin order
+cmdline=''
+for line in $add_cmdline
+do
+	duplicated_word=0
+	for line1 in ${origin_cmdline}
+	do
+		if [ ${line} = ${line1} ];then
+			duplicated_word=1
+		fi
+	done
+
+	if [ ${duplicated_word} = 0 ];then
+		cmdline+=${line}' '
+	fi
+done
+
+cmdline=${origin_cmdline}' '${cmdline}
+
+echo \''$a GRUB_CMDLINE_LINUX_DEFAULT="'${cmdline}'"'\' ${filename} | xargs sed -i
+
 sed -i '$a GRUB_TIMEOUT=20' ${filename}
 
 sync