mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2026-01-05 23:57:10 +00:00
HV: treewide: enforce unsignedness of pcpu_id
In the hypervisor, physical cpu id is defined as "int" or "uint32_t"
type in the hypervisor. So there are some sign conversion issues
about physical cpu id (pcpu_id) reported by static analysis tool.
Sign conversion violates the rules of MISRA C:2012.
In this patch, define physical cpu id as "uint16_t" type for all
modules in the hypervisor and change related codes. The valid
range of pcpu_id is 0~65534, INVALID_PCPU_ID is defined to the
invalid pcpu_id for error detection, BROADCAST_PCPU_ID is
broadcast pcpu_id used to notify all valid pcpu.
The type of pcpu_id in the struct vcpu and vcpu_id is "int" type,
this will be fixed in another patch.
V1-->V2:
* Change the type of pcpu_id from uint32_t to uint16_t;
* Define INVALID_PCPU_ID for error detection;
* Define BROADCAST_PCPU_ID to notify all valid pcpu.
V2-->V3:
* Update comments for INVALID_PCPU_ID and BROADCAST_PCPU_ID;
* Update addtional pcpu_id;
* Convert hexadecimals to unsigned to meet the type of pcpu_id;
* Clean up for MIN_PCPU_ID and MAX_PCPU_ID, they will be
defined by configuration.
Note: fix bug in the init_lapic(), the pcpu_id shall be less than 8,
this is constraint by implement in the init_lapic().
Signed-off-by: Xiangyang Wu <xiangyang.wu@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
@@ -147,10 +147,10 @@ struct acrn_create_vm {
|
||||
*/
|
||||
struct acrn_create_vcpu {
|
||||
/** the virtual CPU ID for the VCPU created */
|
||||
uint32_t vcpu_id;
|
||||
uint16_t vcpu_id;
|
||||
|
||||
/** the physical CPU ID for the VCPU created */
|
||||
uint32_t pcpu_id;
|
||||
uint16_t pcpu_id;
|
||||
} __aligned(8);
|
||||
|
||||
/**
|
||||
|
||||
@@ -169,7 +169,7 @@ struct set_memmaps {
|
||||
*/
|
||||
struct sbuf_setup_param {
|
||||
/** sbuf physical cpu id */
|
||||
uint32_t pcpu_id;
|
||||
uint16_t pcpu_id;
|
||||
|
||||
/** sbuf id */
|
||||
uint32_t sbuf_id;
|
||||
|
||||
Reference in New Issue
Block a user