From 46c72d963d451769d1e157f3802d8078993398ec Mon Sep 17 00:00:00 2001 From: Qi Yadong Date: Tue, 26 Feb 2019 09:12:19 +0800 Subject: [PATCH] hv: fix possibility of using uninitialized params 'len' and 'arg' might be used uninitialized in abl_seed_parse(). Fix them by setting initial value. Tracked-On: #2618 Signed-off-by: Qi Yadong --- hypervisor/boot/sbl/abl_seed_parse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hypervisor/boot/sbl/abl_seed_parse.c b/hypervisor/boot/sbl/abl_seed_parse.c index b3a57d733..389cd2be4 100644 --- a/hypervisor/boot/sbl/abl_seed_parse.c +++ b/hypervisor/boot/sbl/abl_seed_parse.c @@ -104,15 +104,15 @@ static void parse_seed_list_abl(void *param_addr) */ bool abl_seed_parse(struct acrn_vm *vm, char *cmdline, char *out_arg, uint32_t out_len) { - char *arg, *arg_end; + char *arg = NULL, *arg_end; char *param; void *param_addr; - uint32_t len, i; + uint32_t len = 0U, i; bool parse_success = false; if (cmdline != NULL) { - for(i = 0U; abl_seed_arg[i] != NULL; i++) { + for (i = 0U; abl_seed_arg[i] != NULL; i++) { len = strnlen_s(abl_seed_arg[i], MEM_1K); arg = strstr_s((const char *)cmdline, MEM_2K, abl_seed_arg[i], len); if (arg != NULL) {