From 4acaeb91bdfb0e90a0b3ef02735981db5ea92e44 Mon Sep 17 00:00:00 2001 From: Yonghua Huang Date: Wed, 2 Jun 2021 14:45:22 +0800 Subject: [PATCH] hv: remove unnecessary ASSERT in vlapic_write vlapic_write handle 'offset' that is valid and ignore all other invalid 'offset'. so ASSERT on this 'offset' input is unnecessary. This patch removes above ASSERT to avoid potential hypervisor crash by guest malicious input when debug build is used. Tracked-On: #6131 Signed-off-by: Yonghua Huang --- hypervisor/arch/x86/guest/vlapic.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hypervisor/arch/x86/guest/vlapic.c b/hypervisor/arch/x86/guest/vlapic.c index 7b6561b63..f856a2acd 100644 --- a/hypervisor/arch/x86/guest/vlapic.c +++ b/hypervisor/arch/x86/guest/vlapic.c @@ -1469,9 +1469,6 @@ static int32_t vlapic_write(struct acrn_vlapic *vlapic, uint32_t offset, uint64_ uint32_t data32 = (uint32_t)data; int32_t ret = 0; - ASSERT(((offset & 0xfU) == 0U) && (offset < PAGE_SIZE), - "%s: invalid offset %#x", __func__, offset); - dev_dbg(DBG_LEVEL_VLAPIC, "vlapic write offset %#x, data %#lx", offset, data); if (offset <= sizeof(*lapic)) {