github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-09 12:08:30 +00:00
Code Issues Projects Releases Wiki Activity

config_tools: do not create leaf nodes without default values

Browse Source 
Today the default value populator will always create a node if it is
required by the schema but not provided in the given XML file. This could
hide issues in a given scenario XML if a node does not have default
values (i.e. require user's inputs) but accepts empty text.

This patch avoids the creation of nodes without a default value so that, at
validation stage, missing of essential data is always reported.

Tracked-On: #6690
Signed-off-by: Junjie Mao <junjie.mao@intel.com>
This commit is contained in:
Junjie Mao 2022-02-18 22:29:41 +08:00 committed by acrnsi-robot
parent 06eacfa32d
commit 4fb6ad247a
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
misc/config_tools/scenario_config/default_populator.py
View File

@ -14,9 +14,14 @@ class DefaultValuePopulator(ScenarioTransformer):
element_name = xsd_element_node.get("name") element_name = xsd_element_node.get("name")
default_value = xsd_element_node.get("default") default_value = xsd_element_node.get("default")
# If the node is neither of a complex type (i.e. it does not have an child node) nor has a default value, do not
# create the node at all. Users are required to fill in proper values in such nodes, and missing any of them
# shall trigger a validation error.
if self.complex_type_of_element(xsd_element_node) is None and default_value is None:
return []
new_node = etree.Element(element_name) new_node = etree.Element(element_name)
if default_value is not None: new_node.text = default_value
new_node.text = default_value
if new_node_index is not None: if new_node_index is not None:
xml_parent_node.insert(new_node_index, new_node) xml_parent_node.insert(new_node_index, new_node)