From 5533263e70d570a2a070c0d3da3e67010ec84b92 Mon Sep 17 00:00:00 2001 From: xiaojin2 Date: Thu, 23 May 2019 04:05:18 +0000 Subject: [PATCH] tools:acrn-crashlog: fix error logs writing to server This patch is to fix error logs in client sending to server via socket. Since gdb inherits the socket descriptor of client which is used as its stderr, in this case, the error logs from gdb will mess up server, so closing the inheritance when the socket is created. Tracked-On: #3200 Signed-off-by: xiaojin2 Reviewed-by: Liu, Xinwu Acked-by: Chen, Gang Acked-by: Anthony Xu --- tools/acrn-crashlog/usercrash/client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/acrn-crashlog/usercrash/client.c b/tools/acrn-crashlog/usercrash/client.c index 18a31a361..a6cc758b4 100644 --- a/tools/acrn-crashlog/usercrash/client.c +++ b/tools/acrn-crashlog/usercrash/client.c @@ -86,7 +86,7 @@ static int usercrashd_connect(int pid, int *usercrashd_socket, return -1; } sockfd = socket_local_client(SOCKET_NAME, strlen(SOCKET_NAME), - SOCK_SEQPACKET); + SOCK_SEQPACKET | SOCK_CLOEXEC); if (sockfd == -1) { LOGE("failed to connect to usercrashd, error (%s)\n", strerror(errno));