github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-08 01:54:44 +00:00
Code Issues Projects Releases Wiki Activity

dm: refine assert usage

Browse Source 
Remove unnecessary assert and add error handling when required.

Tracked-On: #3252
Signed-off-by: Jian Jun Chen <jian.jun.chen@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
This commit is contained in:
Jian Jun Chen
2019-06-18 13:38:37 +08:00
committed by ACRN System Integration
parent 0a8bf6cee4
commit 56469f3edc
4 changed files with 26 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
devicemodel/hw/pci/virtio/virtio_console.c
View File

@@ -39,7 +39,6 @@
#include <stdbool.h>
#include <string.h>
#include <unistd.h>
#include <assert.h>
#include <pthread.h>
#include <termios.h>
#include <limits.h>
@@ -272,15 +271,13 @@ virtio_console_add_port(struct virtio_console *console, const char *name,
static void
virtio_console_control_tx(struct virtio_console_port *port, void *arg,
struct iovec *iov, int niov)
struct iovec *iov, int niov __attribute__((unused)))
{
struct virtio_console *console;
struct virtio_console_port *tmp;
struct virtio_console_control resp, *ctrl;
int i;
assert(niov == 1);
console = port->console;
ctrl = (struct virtio_console_control *)iov->iov_base;
@@ -363,8 +360,10 @@ virtio_console_control_send(struct virtio_console *console,
return;
n = vq_getchain(vq, &idx, &iov, 1, NULL);
assert(n == 1);
if (n < 1) {
WPRINTF(("vtcon: control_send vq_getchain error %d\n", n));
return;
}
memcpy(iov.iov_base, ctrl, sizeof(struct virtio_console_control));
if (payload != NULL && len > 0)