From 5c3e4d1a7e1ed05b150ee1ded58ddab4007287ea Mon Sep 17 00:00:00 2001 From: "Yan, Like" Date: Wed, 29 Aug 2018 09:54:23 +0800 Subject: [PATCH] tools: acrntrace: fix a variable uninitialized issue 'err' may be used uninitialized and be dereferenced NULL. This commit fix the reported issue via initializing 'err' to 0, and return 'err' at the end of the func. Tracked-On: #1157 Signed-off-by: Yan, Like --- tools/acrntrace/acrntrace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/acrntrace/acrntrace.c b/tools/acrntrace/acrntrace.c index 436b6954d..66e33a873 100644 --- a/tools/acrntrace/acrntrace.c +++ b/tools/acrntrace/acrntrace.c @@ -154,7 +154,7 @@ static int get_cpu_num(void) static int create_trace_file_dir(char *dir) { - int err; + int err = 0; char cmd[CMD_MAX_LEN]; char time_str[TIME_STR_LEN]; time_t timep; @@ -193,7 +193,7 @@ static int create_trace_file_dir(char *dir) pr_dbg("dir %s creted\n", dir); - return WIFEXITED(err) ? WEXITSTATUS(err) : EXIT_FAILURE; + return err; } /* function executed in each consumer thread */