github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-08 18:14:53 +00:00
Code Issues Projects Releases Wiki Activity

tools:acrn-crashlog: Enhance some functions

Browse Source 
The changes include:

1. modify the outparam only in successful cases.
2. return -1 instead of  a errno-style value if error happens.
3. check return value of strrchr.

Tracked-On: #971
Signed-off-by: Liu, Xinwu <xinwu.liu@intel.com>
Acked-by: Chen Gang <gang.c.chen@intel.com>
This commit is contained in:
Liu, Xinwu
2018-08-01 15:29:51 +08:00
committed by lijinxia
parent 10f0bb012a
commit 5e32c0227f
4 changed files with 63 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
tools/acrn-crashlog/acrnprobe/sender.c
View File

@@ -224,8 +224,7 @@ static void telemd_get_log(struct log_t *log, void *data)
count = ac_scandir(d->srcdir, &filelist, filter_filename_substr,
log->name, NULL);
if (count < 0) {
LOGE("search (%s) in dir (%s) failed, error (%s)\n", log->name,
d->srcdir, strerror(count));
LOGE("search (%s) in dir (%s) failed\n", log->name, d->srcdir);
return;
}
if (!count) {
@@ -289,8 +288,7 @@ static void crashlog_get_log(struct log_t *log, void *data)
const int count = config_fmt_to_files(log->path, &files);
if (count < 0) {
LOGE("parse config format (%s) failed, error (%s)\n",
log->path, strerror(count));
LOGE("parse config format (%s) failed\n", log->path);
return;
}
if (!count) {
@@ -597,9 +595,8 @@ static int telemd_new_vmevent(const char *line_to_sync,
res = find_file(crashlog->outdir, log + strlen("/logs/"),
2, &vmlogpath, 1);
if (res < 0) {
LOGE("find (%s) in (%s) failed, strerror (%s)\n",
log + strlen("/logs/"), crashlog->outdir,
strerror(-res));
LOGE("find (%s) in (%s) failed\n",
log + strlen("/logs/"), crashlog->outdir);
return VMEVT_DEFER;
}
}