github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-06 03:10:13 +00:00
Code Issues Projects Releases Wiki Activity

tools:acrn-crashlog: Enhance some functions

Browse Source 
The changes include:

1. modify the outparam only in successful cases.
2. return -1 instead of  a errno-style value if error happens.
3. check return value of strrchr.

Tracked-On: #971
Signed-off-by: Liu, Xinwu <xinwu.liu@intel.com>
Acked-by: Chen Gang <gang.c.chen@intel.com>
This commit is contained in:
Liu, Xinwu
2018-08-01 15:29:51 +08:00
committed by lijinxia
parent 10f0bb012a
commit 5e32c0227f
4 changed files with 63 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/acrn-crashlog/usercrash/protocol.c
View File

@@ -40,11 +40,11 @@ static int socket_make_sockaddr_un(const char *name,
socket_len = strlen(RESERVED_SOCKET_PREFIX);
if (socket_len >= SUN_PATH_MAX)
return -1;
strcpy(p_addr->sun_path, RESERVED_SOCKET_PREFIX);
strncpy(p_addr->sun_path, RESERVED_SOCKET_PREFIX, socket_len + 1);
name_len = strlen(name);
if (name_len >= (SUN_PATH_MAX - socket_len))
return -1;
strncat(p_addr->sun_path, name, SUN_PATH_MAX - socket_len);
strncat(p_addr->sun_path, name, name_len);
p_addr->sun_family = AF_LOCAL;
*alen = name_len + socket_len +
@@ -111,8 +111,7 @@ static int socket_bind(int fd, const char *name)
name_len = strlen(name);
if (name_len >= SUN_PATH_MAX)
return -1;
strncpy(addr.sun_path, name, SUN_PATH_MAX);
addr.sun_path[SUN_PATH_MAX - 1] = '\0';
strncpy(addr.sun_path, name, name_len + 1);
unlink(addr.sun_path);
alen = strlen(addr.sun_path) + sizeof(addr.sun_family);