github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-08 11:39:39 +00:00
Code Issues Projects Releases Wiki Activity

HV:fixed "Pointer param should be declared pointer to const"

Browse Source 
Pointer param should be declared pointer to const if
the parameter is keeped read-only.
This patch changes pointer param whose name is vm.

Tracked-On:#861
Signed-off-by: Huihuang Shi <huihuang.shi@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Huihuang Shi 2018-10-18 16:18:45 +08:00 committed by Xie, Nanlin
parent 40dbdcde4f
commit 60b216a460
13 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
hypervisor/arch/x86/assign.c
View File

@ -17,7 +17,7 @@
*/ */
static inline struct ptdev_remapping_info * static inline struct ptdev_remapping_info *
ptdev_lookup_entry_by_sid(uint32_t intr_type, ptdev_lookup_entry_by_sid(uint32_t intr_type,
union source_id *sid, struct vm *vm) union source_id *sid,const struct vm *vm)
{ {
struct ptdev_remapping_info *entry; struct ptdev_remapping_info *entry;
struct list_head *pos; struct list_head *pos;
@ -43,7 +43,7 @@ is_entry_active(struct ptdev_remapping_info *entry)
return atomic_load32(&entry->active) == ACTIVE_FLAG; return atomic_load32(&entry->active) == ACTIVE_FLAG;
} }
static bool ptdev_hv_owned_intx(struct vm *vm, union source_id *virt_sid) static bool ptdev_hv_owned_intx(const struct vm *vm, union source_id *virt_sid)
{ {
/* vm0 vuart pin is owned by hypervisor under debug version */ /* vm0 vuart pin is owned by hypervisor under debug version */
if (is_vm0(vm) && (virt_sid->intx_id.pin == COM1_IRQ)) { if (is_vm0(vm) && (virt_sid->intx_id.pin == COM1_IRQ)) {
@ -230,7 +230,7 @@ add_msix_remapping(struct vm *vm, uint16_t virt_bdf, uint16_t phys_bdf,
/* deactive & remove mapping entry of vbdf:entry_nr for vm */ /* deactive & remove mapping entry of vbdf:entry_nr for vm */
static void static void
remove_msix_remapping(struct vm *vm, uint16_t virt_bdf, uint32_t entry_nr) remove_msix_remapping(const struct vm *vm, uint16_t virt_bdf, uint32_t entry_nr)
{ {
struct ptdev_remapping_info *entry; struct ptdev_remapping_info *entry;
DEFINE_MSI_SID(virt_sid, virt_bdf, entry_nr); DEFINE_MSI_SID(virt_sid, virt_bdf, entry_nr);
@ -324,7 +324,7 @@ add_intx_remapping(struct vm *vm, uint8_t virt_pin,
} }
/* deactive & remove mapping entry of vpin for vm */ /* deactive & remove mapping entry of vpin for vm */
static void remove_intx_remapping(struct vm *vm, uint8_t virt_pin, bool pic_pin) static void remove_intx_remapping(const struct vm *vm, uint8_t virt_pin, bool pic_pin)
{ {
uint32_t phys_irq; uint32_t phys_irq;
struct ptdev_remapping_info *entry; struct ptdev_remapping_info *entry;
@ -732,7 +732,7 @@ int ptdev_add_intx_remapping(struct vm *vm, uint8_t virt_pin, uint8_t phys_pin,
/* /*
* @pre vm != NULL * @pre vm != NULL
*/ */
void ptdev_remove_intx_remapping(struct vm *vm, uint8_t virt_pin, bool pic_pin) void ptdev_remove_intx_remapping(const struct vm *vm, uint8_t virt_pin, bool pic_pin)
{ {
remove_intx_remapping(vm, virt_pin, pic_pin); remove_intx_remapping(vm, virt_pin, pic_pin);
} }
@ -761,7 +761,7 @@ int ptdev_add_msix_remapping(struct vm *vm, uint16_t virt_bdf,
/* /*
* @pre vm != NULL * @pre vm != NULL
*/ */
void ptdev_remove_msix_remapping(struct vm *vm, uint16_t virt_bdf, void ptdev_remove_msix_remapping(const struct vm *vm, uint16_t virt_bdf,
uint32_t vector_count) uint32_t vector_count)
{ {
uint32_t i; uint32_t i;

4
hypervisor/arch/x86/guest/pm.c
View File

@ -6,9 +6,9 @@
#include <hypervisor.h> #include <hypervisor.h>
int validate_pstate(struct vm *vm, uint64_t perf_ctl) int validate_pstate(const struct vm *vm, uint64_t perf_ctl)
{ {
struct cpu_px_data *px_data; const struct cpu_px_data *px_data;
int i, px_cnt; int i, px_cnt;
if (is_vm0(vm)) { if (is_vm0(vm)) {

4
hypervisor/arch/x86/guest/vlapic.c
View File

@ -140,11 +140,11 @@ static uint16_t vm_apicid2vcpu_id(struct vm *vm, uint8_t lapicid)
} }
static uint64_t static uint64_t
vm_active_cpus(struct vm *vm) vm_active_cpus(const struct vm *vm)
{ {
uint64_t dmask = 0UL; uint64_t dmask = 0UL;
uint16_t i; uint16_t i;
struct vcpu *vcpu; const struct vcpu *vcpu;
foreach_vcpu(i, vm, vcpu) { foreach_vcpu(i, vm, vcpu) {
bitmap_set_lock(vcpu->vcpu_id, &dmask); bitmap_set_lock(vcpu->vcpu_id, &dmask);

2
hypervisor/arch/x86/guest/vm.c
View File

@ -30,7 +30,7 @@ static inline uint16_t alloc_vm_id(void)
return INVALID_VM_ID; return INVALID_VM_ID;
} }
static inline void free_vm_id(struct vm *vm) static inline void free_vm_id(const struct vm *vm)
{ {
bitmap_clear_lock(vm->vm_id, &vmid_bitmap); bitmap_clear_lock(vm->vm_id, &vmid_bitmap);
} }

6
hypervisor/common/hypercall.c
View File

@ -72,7 +72,7 @@ int32_t hcall_get_api_version(struct vm *vm, uint64_t param)
*@pre Pointer vm shall point to VM0 *@pre Pointer vm shall point to VM0
*/ */
static int32_t static int32_t
handle_virt_irqline(struct vm *vm, uint16_t target_vmid, handle_virt_irqline(const struct vm *vm, uint16_t target_vmid,
struct acrn_irqline *param, uint32_t operation) struct acrn_irqline *param, uint32_t operation)
{ {
int32_t ret = 0; int32_t ret = 0;
@ -333,7 +333,7 @@ int32_t hcall_set_vcpu_regs(struct vm *vm, uint16_t vmid, uint64_t param)
/** /**
*@pre Pointer vm shall point to VM0 *@pre Pointer vm shall point to VM0
*/ */
int32_t hcall_set_irqline(struct vm *vm, uint16_t vmid, int32_t hcall_set_irqline(const struct vm *vm, uint16_t vmid,
struct acrn_irqline_ops *ops) struct acrn_irqline_ops *ops)
{ {
struct vm *target_vm = get_vm_from_vmid(vmid); struct vm *target_vm = get_vm_from_vmid(vmid);
@ -1073,7 +1073,7 @@ int32_t hcall_vm_intr_monitor(struct vm *vm, uint16_t vmid, uint64_t param)
/** /**
*@pre Pointer vm shall point to VM0 *@pre Pointer vm shall point to VM0
*/ */
int32_t hcall_set_callback_vector(struct vm *vm, uint64_t param) int32_t hcall_set_callback_vector(const struct vm *vm, uint64_t param)
{ {
if (!is_vm0(vm)) { if (!is_vm0(vm)) {
pr_err("%s: Targeting to service vm", __func__); pr_err("%s: Targeting to service vm", __func__);

4
hypervisor/common/ptdev.c
View File

@ -119,7 +119,7 @@ release_entry(struct ptdev_remapping_info *entry)
/* require ptdev_lock protect */ /* require ptdev_lock protect */
static void static void
release_all_entries(struct vm *vm) release_all_entries(const struct vm *vm)
{ {
struct ptdev_remapping_info *entry; struct ptdev_remapping_info *entry;
struct list_head *pos, *tmp; struct list_head *pos, *tmp;
@ -202,7 +202,7 @@ void ptdev_init(void)
register_softirq(SOFTIRQ_PTDEV, ptdev_softirq); register_softirq(SOFTIRQ_PTDEV, ptdev_softirq);
} }
void ptdev_release_all_entries(struct vm *vm) void ptdev_release_all_entries(const struct vm *vm)
{ {
/* VM already down */ /* VM already down */
spinlock_obtain(&ptdev_lock); spinlock_obtain(&ptdev_lock);

2
hypervisor/dm/vioapic.c
View File

@ -523,7 +523,7 @@ vioapic_cleanup(struct acrn_vioapic *vioapic)
} }
uint32_t uint32_t
vioapic_pincount(struct vm *vm) vioapic_pincount(const struct vm *vm)
{ {
if (is_vm0(vm)) { if (is_vm0(vm)) {
return REDIR_ENTRIES_HW; return REDIR_ENTRIES_HW;

4
hypervisor/include/arch/x86/assign.h
View File

@ -17,10 +17,10 @@ int ptdev_intx_pin_remap(struct vm *vm, uint8_t virt_pin,
enum ptdev_vpin_source vpin_src); enum ptdev_vpin_source vpin_src);
int ptdev_add_intx_remapping(struct vm *vm, uint8_t virt_pin, uint8_t phys_pin, int ptdev_add_intx_remapping(struct vm *vm, uint8_t virt_pin, uint8_t phys_pin,
bool pic_pin); bool pic_pin);
void ptdev_remove_intx_remapping(struct vm *vm, uint8_t virt_pin, bool pic_pin); void ptdev_remove_intx_remapping(const struct vm *vm, uint8_t virt_pin, bool pic_pin);
int ptdev_add_msix_remapping(struct vm *vm, uint16_t virt_bdf, int ptdev_add_msix_remapping(struct vm *vm, uint16_t virt_bdf,
uint16_t phys_bdf, uint32_t vector_count); uint16_t phys_bdf, uint32_t vector_count);
void ptdev_remove_msix_remapping(struct vm *vm, uint16_t virt_bdf, void ptdev_remove_msix_remapping(const struct vm *vm, uint16_t virt_bdf,
uint32_t vector_count); uint32_t vector_count);
#endif /* ASSIGN_H */ #endif /* ASSIGN_H */

2
hypervisor/include/arch/x86/guest/guest_pm.h
View File

@ -9,7 +9,7 @@
void vm_setup_cpu_state(struct vm *vm); void vm_setup_cpu_state(struct vm *vm);
int vm_load_pm_s_state(struct vm *vm); int vm_load_pm_s_state(struct vm *vm);
int validate_pstate(struct vm *vm, uint64_t perf_ctl); int validate_pstate(const struct vm *vm, uint64_t perf_ctl);
void register_pm1ab_handler(struct vm *vm); void register_pm1ab_handler(struct vm *vm);
#endif /* PM_H */ #endif /* PM_H */

2
hypervisor/include/arch/x86/guest/vioapic.h
View File

@ -57,7 +57,7 @@ void vioapic_set_irq(struct vm *vm, uint32_t irq, uint32_t operation);
void vioapic_set_irq_nolock(struct vm *vm, uint32_t irq, uint32_t operation); void vioapic_set_irq_nolock(struct vm *vm, uint32_t irq, uint32_t operation);
void vioapic_update_tmr(struct vcpu *vcpu); void vioapic_update_tmr(struct vcpu *vcpu);
uint32_t vioapic_pincount(struct vm *vm); uint32_t vioapic_pincount(const struct vm *vm);
void vioapic_process_eoi(struct vm *vm, uint32_t vector); void vioapic_process_eoi(struct vm *vm, uint32_t vector);
void vioapic_get_rte(struct vm *vm, uint32_t pin, union ioapic_rte *rte); void vioapic_get_rte(struct vm *vm, uint32_t pin, union ioapic_rte *rte);
int vioapic_mmio_access_handler(struct vcpu *vcpu, int vioapic_mmio_access_handler(struct vcpu *vcpu,

2
hypervisor/include/arch/x86/guest/vm.h
View File

@ -194,7 +194,7 @@ struct vm_description {
#endif #endif
}; };
static inline bool is_vm0(struct vm *vm) static inline bool is_vm0(const struct vm *vm)
{ {
return (vm->vm_id) == 0U; return (vm->vm_id) == 0U;
} }

4
hypervisor/include/common/hypercall.h
View File

@ -215,7 +215,7 @@ int32_t hcall_pulse_irqline(struct vm *vm, uint16_t vmid, uint64_t param);
* @pre Pointer vm shall point to VM0 * @pre Pointer vm shall point to VM0
* @return 0 on success, non-zero on error. * @return 0 on success, non-zero on error.
*/ */
int32_t hcall_set_irqline(struct vm *vm, uint16_t vmid, int32_t hcall_set_irqline(const struct vm *vm, uint16_t vmid,
struct acrn_irqline_ops *ops); struct acrn_irqline_ops *ops);
/** /**
* @brief inject MSI interrupt * @brief inject MSI interrupt
@ -502,7 +502,7 @@ int64_t hcall_save_restore_sworld_ctx(struct vcpu *vcpu);
* @pre Pointer vm shall point to VM0 * @pre Pointer vm shall point to VM0
* @return 0 on success, non-zero on error. * @return 0 on success, non-zero on error.
*/ */
int32_t hcall_set_callback_vector(struct vm *vm, uint64_t param); int32_t hcall_set_callback_vector(const struct vm *vm, uint64_t param);
/** /**
* @} * @}

2
hypervisor/include/common/ptdev.h
View File

@ -72,7 +72,7 @@ extern spinlock_t ptdev_lock;
void ptdev_softirq(uint16_t pcpu_id); void ptdev_softirq(uint16_t pcpu_id);
void ptdev_init(void); void ptdev_init(void);
void ptdev_release_all_entries(struct vm *vm); void ptdev_release_all_entries(const struct vm *vm);
struct ptdev_remapping_info *ptdev_dequeue_softirq(struct vm *vm); struct ptdev_remapping_info *ptdev_dequeue_softirq(struct vm *vm);
struct ptdev_remapping_info *alloc_entry(struct vm *vm, struct ptdev_remapping_info *alloc_entry(struct vm *vm,