github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-08 10:04:42 +00:00
Code Issues Projects Releases Wiki Activity

dm: reduce potential crash caused by LIST_FOREACH

Browse Source 
When removing node in list, list_foreach_safe will be safer than
LIST_FOREACH.

Tracked-On: #3778
Signed-off-by: Junhao Gao <junhao.gao@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
Acked-by: Yu Wang <yu1.wang@intel.com>
This commit is contained in:
Junhao Gao
2019-09-23 21:50:26 +00:00
committed by ACRN System Integration
parent e6e0e27788
commit 72232daafe
2 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
devicemodel/hw/pci/gsi_sharing.c
View File

@@ -13,6 +13,7 @@
#include <pciaccess.h>
#include "pci_core.h"
#include "mevent.h"
#define MAX_DEV_PER_GSI 4
@@ -117,7 +118,7 @@ create_gsi_sharing_groups(void)
uint8_t gsi;
char *dev_name;
int i, error, msi_support;
struct gsi_sharing_group *group = NULL;
struct gsi_sharing_group *group = NULL, *temp = NULL;
error = pciaccess_init();
if (error < 0)
@@ -144,7 +145,7 @@ create_gsi_sharing_groups(void)
* clean up gsg_head - the list for gsi_sharing_group
* delete the element without gsi sharing condition (shared_dev_num < 2)
*/
LIST_FOREACH(group, &gsg_head, gsg_list) {
list_foreach_safe(group, &gsg_head, gsg_list, temp) {
if (group->shared_dev_num < 2) {
LIST_REMOVE(group, gsg_list);
free(group);
@@ -181,7 +182,7 @@ update_pt_info(uint16_t phys_bdf)
int
check_gsi_sharing_violation(void)
{
struct gsi_sharing_group *group;
struct gsi_sharing_group *group, *temp;
int i, error, violation;
error = 0;
@@ -226,7 +227,7 @@ check_gsi_sharing_violation(void)
}
/* destroy the gsg_head after all the checks have been done */
LIST_FOREACH(group, &gsg_head, gsg_list) {
list_foreach_safe(group, &gsg_head, gsg_list, temp) {
LIST_REMOVE(group, gsg_list);
free(group);
}