github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-07-18 01:12:21 +00:00
Code Issues Projects Releases Wiki Activity

HV: Clean up the unused or legacy code-like comment

Browse Source 
Removed comment out unused code in vmexit.c, sprintf.c and vmcall.c
Minor fix in vmx.c to prevent Misra-c consider it as a piece of
code.

Signed-off-by: Yang, Yu-chu <yu-chu.yang@intel.com>
Acked-by: Anthony Xu <anthony.xu@intel.com>
This commit is contained in:
Yang, Yu-chu 2018-07-17 12:46:45 -07:00 committed by lijinxia
parent c776137169
commit 7aec6799a1
4 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hypervisor/arch/x86/guest/vmcall.c
View File

@ -24,10 +24,6 @@ int vmcall_vmexit_handler(struct vcpu *vcpu)
uint64_t param1 = cur_context->guest_cpu_regs.regs.rdi; uint64_t param1 = cur_context->guest_cpu_regs.regs.rdi;
/* hypercall param2 from guest*/ /* hypercall param2 from guest*/
uint64_t param2 = cur_context->guest_cpu_regs.regs.rsi; uint64_t param2 = cur_context->guest_cpu_regs.regs.rsi;
/* hypercall param3 from guest, reserved*/
/* uint64_t param3 = cur_context->guest_cpu_regs.regs.rdx; */
/* hypercall param4 from guest, reserved*/
/* uint64_t param4 = cur_context->guest_cpu_regs.regs.rcx; */
if (!is_hypercall_from_ring0()) { if (!is_hypercall_from_ring0()) {
pr_err("hypercall is only allowed from RING-0!\n"); pr_err("hypercall is only allowed from RING-0!\n");

2
hypervisor/arch/x86/vmexit.c
View File

@ -236,8 +236,6 @@ static int unhandled_vmexit_handler(struct vcpu *vcpu)
pr_err("Exit qualification: 0x%016llx ", pr_err("Exit qualification: 0x%016llx ",
exec_vmread(VMX_EXIT_QUALIFICATION)); exec_vmread(VMX_EXIT_QUALIFICATION));
/* while(1); */
TRACE_2L(TRACE_VMEXIT_UNHANDLED, vcpu->arch_vcpu.exit_reason, 0UL); TRACE_2L(TRACE_VMEXIT_UNHANDLED, vcpu->arch_vcpu.exit_reason, 0UL);
return 0; return 0;

2
hypervisor/arch/x86/vmx.c
View File

@ -635,7 +635,7 @@ static void init_guest_state(struct vcpu *vcpu)
} }
} else { } else {
/* AP is initialized with real mode /* AP is initialized with real mode
* and CS value is left shift 8 bits from sipi vector; * and CS value is left shift 8 bits from sipi vector.
*/ */
sel = vcpu->arch_vcpu.sipi_vector << 8U; sel = vcpu->arch_vcpu.sipi_vector << 8U;
base = sel << 4U; base = sel << 4U;

4
hypervisor/lib/sprintf.c
View File

@ -608,10 +608,6 @@ int do_print(const char *fmt, struct print_param *param,
/* pointer argument */ /* pointer argument */
else if (ch == 'p') { else if (ch == 'p') {
param->vars.flags |= PRINT_FLAG_ALTERNATE_FORM; param->vars.flags |= PRINT_FLAG_ALTERNATE_FORM;
/* XXXCRG res=print_pow2(param,
* (uint32_t) __builtin_va_arg(args,
* void *),4);
*/
res = print_pow2(param, (uint64_t) res = print_pow2(param, (uint64_t)
__builtin_va_arg(args, void *), 4U); __builtin_va_arg(args, void *), 4U);
} }