From 3629ffbb2d01b7342c8206c94fd86a36325b0828 Mon Sep 17 00:00:00 2001
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Date: Mon, 29 Jul 2024 02:45:00 +0000
Subject: [PATCH 1/3] debian: create symlink to board/scenario xml in
 /usr/share/acrn

Tracked-On: #8667
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
---
 debian/acrn-hypervisor.postinst.in | 6 ++++++
 debian/acrn-hypervisor.postrm.in   | 2 ++
 debian/acrn-hypervisor.prerm.in    | 2 ++
 3 files changed, 10 insertions(+)

diff --git a/debian/acrn-hypervisor.postinst.in b/debian/acrn-hypervisor.postinst.in
index d916c3af2..8085bf125 100644
--- a/debian/acrn-hypervisor.postinst.in
+++ b/debian/acrn-hypervisor.postinst.in
@@ -19,6 +19,8 @@ ACRNMAP="${ACRNDIR}/${BOARD}/${SCENARIO}/acrn.${BOARD}.${SCENARIO}.map"
 ACRNBIN="${ACRNDIR}/${BOARD}/${SCENARIO}/acrn.${BOARD}.${SCENARIO}.bin"
 ACRNACPI="${ACRNDIR}/${BOARD}/${SCENARIO}/acpi"
 ACRNETC="${ACRNDIR}/${BOARD}/${SCENARIO}/etc"
+ACRNBOARD="${ACRNDIR}/${BOARD}/board.xml"
+ACRNSCENARIO="${ACRNDIR}/${BOARD}/${SCENARIO}/scenario.xml"
 
 case "$1" in
     configure)
@@ -26,6 +28,10 @@ case "$1" in
             cp ${ACRNCFG} /boot/acrn-@acrnversion@.config
             cp ${ACRNMAP} /boot/acrn-@acrnversion@.map
             cp ${ACRNBIN} /boot/acrn-@acrnversion@.bin
+            if [ -f ${ACRNBOARD} ] && [ -f ${ACRNSCENARIO} ]; then
+                ln -sf ${ACRNBOARD} /usr/share/acrn/board.xml
+                ln -sf ${ACRNSCENARIO} /usr/share/acrn/scenario.xml
+            fi
             if [ -d ${ACRNACPI} ]; then
                 cp ${ACRNACPI}/ACPI_VM* /boot
             fi
diff --git a/debian/acrn-hypervisor.postrm.in b/debian/acrn-hypervisor.postrm.in
index a34e2bf41..92b3dc8cc 100644
--- a/debian/acrn-hypervisor.postrm.in
+++ b/debian/acrn-hypervisor.postrm.in
@@ -13,6 +13,8 @@ rm_acrn()
     rm -f /boot/acrn-@acrnversion@.map
     rm -f /boot/acrn-@acrnversion@.bin
     rm -f /boot/ACPI_VM*
+    rm -f /usr/share/acrn/board.xml
+    rm -f /usr/share/acrn/scenario.xml
 }
 
 # summary of how this script can be called:
diff --git a/debian/acrn-hypervisor.prerm.in b/debian/acrn-hypervisor.prerm.in
index fdafffe08..2546dff06 100644
--- a/debian/acrn-hypervisor.prerm.in
+++ b/debian/acrn-hypervisor.prerm.in
@@ -13,6 +13,8 @@ rm_acrn()
     rm -f /boot/acrn-@acrnversion@.map
     rm -f /boot/acrn-@acrnversion@.bin
     rm -f /boot/ACPI_VM*
+    rm -f /usr/share/acrn/board.xml
+    rm -f /usr/share/acrn/scenario.xml
     if [ -f /etc/serial.conf ]; then
         sed '/ START - ACRN HYPERVISOR INSTALL/,/# END - ACRN HYPERVISOR INSTALL/{d}' /etc/serial.conf
     fi

From b538e35b345da333f979b2627aba58bdcf13c49a Mon Sep 17 00:00:00 2001
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Date: Mon, 29 Jul 2024 02:49:56 +0000
Subject: [PATCH 2/3] grub-acrn: read scenario config from
 /usr/share/acrn/scenario.xml

Calling debconfig to concatenating the path of scenario xml may fail
when executing update-grub during package installation as debconf
database might be locked by dpkg. Read scenario config from
/usr/share/acrn/scenario.xml (symlink created when installing
acrn-hypervisor) instead.

Tracked-On: #8667
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
---
 debian/grub/25_linux_acrn | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/debian/grub/25_linux_acrn b/debian/grub/25_linux_acrn
index e06c9dec7..dd167c4c5 100755
--- a/debian/grub/25_linux_acrn
+++ b/debian/grub/25_linux_acrn
@@ -25,23 +25,8 @@ datarootdir="/usr/share"
 
 CLASS="--class gnu-linux --class gnu --class os --class acrn"
 
-# read ACRN config (board/scenario) from debconf
-ACRN_BOARD=$(echo "get acrn-hypervisor/board" | debconf-communicate || true)
-if [ "$(echo "${ACRN_BOARD}" | awk '{print $1}')" != "0" ]; then
-    gettext_printf "ACRN: Cannot access debconf acrn-hypervisor/board: %s" "${ACRN_BOARD}\n" >&2
-    exit 0
-fi
-ACRN_BOARD="$(echo "${ACRN_BOARD}" | awk '{print $2}')"
-
-ACRN_SCENARIO=$(echo "get acrn-hypervisor/scenario" | debconf-communicate || true)
-if [ "$(echo "${ACRN_SCENARIO}" | awk '{print $1}')" != "0" ]; then
-    gettext_printf "ACRN: Cannot access debconf acrn-hypervisor/:scenario %s" "${ACRN_SCENARIO}\n" >&2
-    exit 0
-fi
-ACRN_SCENARIO="$(echo "${ACRN_SCENARIO}" | awk '{print $2}')"
-
 # we obtain any data from scenario config
-ACRN_SCENARIO_FILE=/usr/lib/x86_64-linux-gnu/acrn/${ACRN_BOARD}/${ACRN_SCENARIO}/scenario.xml
+ACRN_SCENARIO_FILE=/usr/share/acrn/scenario.xml
 if [ ! -f ${ACRN_SCENARIO_FILE} ]; then
     gettext_printf "ACRN: Missing scenario config %s\n" "${ACRN_SCENARIO_FILE}" >&2
     exit 0
@@ -376,7 +361,7 @@ EOF
                 gettext_printf "Found ACRN initrd image: %s\n" "${dirname}/${initrd}" >&2
             fi
         else
-            gettext_printf "ACRN: No initrd image for ${ACRN_BOARD}:${ACRN_SCENARIO}\n" >&2
+            gettext_printf "ACRN: No initrd image found for %s\n" "${linux}" >&2
             # "UUID=" magic is parsed by initrds.  Since there's no initrd, it can't work here.
             linux_root_device_thisversion=${GRUB_DEVICE}
         fi

From 5bd843b46d3fd37749d059b9abd2e0fcb94bc700 Mon Sep 17 00:00:00 2001
From: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Date: Mon, 29 Jul 2024 03:07:25 +0000
Subject: [PATCH 3/3] grub-acrn: check installed acrn binary first

grub script should check if any acrn hypervisor is installed on system
first before parsing scenario xml.

Tracked-On: #8667
Signed-off-by: Jiaqing Zhao <jiaqing.zhao@linux.intel.com>
Reviewed-by: Junjie Mao <junjie.mao@intel.com>
---
 debian/grub/25_linux_acrn | 76 +++++++++++++++++++--------------------
 1 file changed, 38 insertions(+), 38 deletions(-)

diff --git a/debian/grub/25_linux_acrn b/debian/grub/25_linux_acrn
index dd167c4c5..6c514cdca 100755
--- a/debian/grub/25_linux_acrn
+++ b/debian/grub/25_linux_acrn
@@ -25,6 +25,44 @@ datarootdir="/usr/share"
 
 CLASS="--class gnu-linux --class gnu --class os --class acrn"
 
+file_is_not_sym () {
+    case "$1" in
+        */acrn-syms-*)
+        return 1;;
+    *)
+        return 0;;
+    esac
+}
+
+# use ELF *.out files for multiboot
+acrn_out_list=
+for i in /boot/acrn*.out; do
+    if grub_file_is_not_garbage "$i" && file_is_not_sym "$i" && grub-file --is-x86-multiboot "$i"; then
+        acrn_out_list="$acrn_out_list $i"
+    fi
+done
+# use raw binary *.bin files for multiboot2
+acrn_bin_list=
+for i in /boot/acrn*.bin; do
+    if grub_file_is_not_garbage "$i" && file_is_not_sym "$i" && grub-file --is-x86-multiboot2 "$i"; then
+        acrn_bin_list="$acrn_bin_list $i"
+    fi
+done
+# we prefer multiboot2
+if [ "x${acrn_bin_list}" != "x" ]; then
+    acrn_list="${acrn_bin_list}"
+    acrn_loader="multiboot2"
+    module_loader="module2"
+else
+    acrn_list="${acrn_out_list}"
+    acrn_loader="multiboot --quirk-modules-after-kernel"
+    module_loader="module"
+fi
+# no ACRN binary found
+if [ "x${acrn_list}" = "x" ] ; then
+    exit 0
+fi
+
 # we obtain any data from scenario config
 ACRN_SCENARIO_FILE=/usr/share/acrn/scenario.xml
 if [ ! -f ${ACRN_SCENARIO_FILE} ]; then
@@ -253,44 +291,6 @@ for i in /boot/vmlinu[xz]-* /vmlinu[xz]-* /boot/kernel-*; do
     fi
 done
 
-file_is_not_sym () {
-    case "$1" in
-        */acrn-syms-*)
-        return 1;;
-    *)
-        return 0;;
-    esac
-}
-
-# use ELF *.out files for multiboot
-acrn_out_list=
-for i in /boot/acrn*.out; do
-    if grub_file_is_not_garbage "$i" && file_is_not_sym "$i" && grub-file --is-x86-multiboot "$i"; then
-        acrn_out_list="$acrn_out_list $i"
-    fi
-done
-# use raw binary *.bin files for multiboot2
-acrn_bin_list=
-for i in /boot/acrn*.bin; do
-    if grub_file_is_not_garbage "$i" && file_is_not_sym "$i" && grub-file --is-x86-multiboot2 "$i"; then
-        acrn_bin_list="$acrn_bin_list $i"
-    fi
-done
-# we prefer multiboot2
-if [ "x${acrn_bin_list}" != "x" ]; then
-    acrn_list="${acrn_bin_list}"
-    acrn_loader="multiboot2"
-    module_loader="module2"
-else
-    acrn_list="${acrn_out_list}"
-    acrn_loader="multiboot --quirk-modules-after-kernel"
-    module_loader="module"
-fi
-# no ACRN binary found
-if [ "x${acrn_list}" = "x" ] ; then
-    exit 0
-fi
-
 prepare_boot_cache=
 boot_device_id=
 acrn_first_entry=