From 8042806676679c385e823400f77d429d499de9bb Mon Sep 17 00:00:00 2001 From: Yifan Liu Date: Mon, 30 May 2022 10:54:27 +0800 Subject: [PATCH] misc: configurator: Fix vUART and IVSHMEM select box missing problem When user adds a vUART or IVSHMEM region and select VMs in selection list, deleting the selected VM could break the selection box. This patch adds a state check against null and undefined value. Tracked-On: #7624 Signed-off-by: Yifan Liu --- .../src/pages/Config/ConfigForm/CustomWidget/IVSHMEM_REGION.vue | 2 +- .../src/pages/Config/ConfigForm/CustomWidget/VUART.vue | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/IVSHMEM_REGION.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/IVSHMEM_REGION.vue index 582712c6a..d82e841a3 100644 --- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/IVSHMEM_REGION.vue +++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/IVSHMEM_REGION.vue @@ -155,7 +155,7 @@ export default { }, methods: { validation(value) { - return value.length != 0; + return (value != null) && (value.length != 0); }, addSharedVM(vms, index) { // add new item after current item diff --git a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/VUART.vue b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/VUART.vue index 7901395ad..c91543f50 100644 --- a/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/VUART.vue +++ b/misc/config_tools/configurator/packages/configurator/src/pages/Config/ConfigForm/CustomWidget/VUART.vue @@ -168,7 +168,7 @@ export default { }, methods: { validation(value) { - return value.length != 0; + return (value != null) && (value.length != 0); }, removeVUARTConnection(index) { this.defaultVal.splice(index, 1);