From 8707834f8320877281c10bf1647f656a16d64988 Mon Sep 17 00:00:00 2001 From: dongshen Date: Thu, 27 Jun 2019 14:05:53 -0700 Subject: [PATCH] HV: remove the function get_bar_base() There is no need to call get_bar_base(), as new_bar is set to val & mask, where mask is the bar size mask, so new_base has already been set to be the bar base address before get_bar_base() is called on it. Tracked-On: #3241 Signed-off-by: dongshen Reviewed-by: Eddie Dong --- hypervisor/dm/vpci/pci_pt.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/hypervisor/dm/vpci/pci_pt.c b/hypervisor/dm/vpci/pci_pt.c index 3a6b636d2..610f16c19 100644 --- a/hypervisor/dm/vpci/pci_pt.c +++ b/hypervisor/dm/vpci/pci_pt.c @@ -33,11 +33,6 @@ #include #include "vpci_priv.h" -static inline uint32_t get_bar_base(uint32_t bar) -{ - return bar & PCIM_BAR_MEM_BASE; -} - /** * @pre vdev != NULL * @pre vdev->vpci != NULL @@ -215,13 +210,12 @@ static void vdev_pt_write_vbar(struct pci_vdev *vdev, uint32_t offset, uint32_t new_bar = val & mask; if (bar_update_normal) { if (is_msix_table_bar) { - vdev->bar[idx].base = get_bar_base(new_bar); + vdev->bar[idx].base = new_bar; vdev_pt_remap_msix_table_bar(vdev); } else { - vdev_pt_remap_generic_mem_vbar(vdev, idx, - get_bar_base(new_bar)); + vdev_pt_remap_generic_mem_vbar(vdev, idx, new_bar); - vdev->bar[idx].base = get_bar_base(new_bar); + vdev->bar[idx].base = new_bar; } } break;