github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-11 05:39:45 +00:00
Code Issues Projects Releases Wiki Activity

hv: arch: fix 'Unused procedure parameter'

Browse Source 
MISRA-C requires that there should be no unused parameters in
functions.

In some cases, we will keep the unused parameters.
vmexit handler is one example. It is used as function pointer.
Some of the vmexit handlers use the input parameter 'vcpu', some of
them don't. We still need to keep the unused parameters 'vcpu' for
those handlers don't use 'vcpu'.

This patch removes the unused parameters that is not being used
unconditionally.

v1 -> v2:
 * remove the non-implemented API 'vlapic_id_write_handler'

Tracked-On: #861
Signed-off-by: Shiqing Gao <shiqing.gao@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Shiqing Gao
2018-09-25 15:05:15 +08:00
committed by lijinxia
parent 2908f09f88
commit 8787c06d3b
17 changed files with 68 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
hypervisor/dm/vpci/vpci.c
View File

@@ -52,8 +52,7 @@ static void pci_cfg_clear_cache(struct pci_addr_info *pi)
pi->cached_enable = 0U;
}
static uint32_t pci_cfg_io_read(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t bytes)
static uint32_t pci_cfg_io_read(struct vm *vm, uint16_t addr, size_t bytes)
{
uint32_t val = 0xFFFFFFFFU;
struct vpci *vpci = &vm->vpci;
@@ -85,8 +84,8 @@ static uint32_t pci_cfg_io_read(__unused struct vm_io_handler *hdlr,
return val;
}
static void pci_cfg_io_write(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t bytes, uint32_t val)
static void pci_cfg_io_write(struct vm *vm, uint16_t addr, size_t bytes,
uint32_t val)
{
struct vpci *vpci = &vm->vpci;
struct pci_addr_info *pi = &vpci->addr_info;

21
hypervisor/dm/vpic.c
View File

@@ -724,8 +724,7 @@ static int vpic_master_handler(struct vm *vm, bool in, uint16_t port,
return vpic_write(vpic, i8259, port, eax);
}
static uint32_t vpic_master_io_read(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width)
static uint32_t vpic_master_io_read(struct vm *vm, uint16_t addr, size_t width)
{
uint32_t val = 0U;
@@ -736,8 +735,8 @@ static uint32_t vpic_master_io_read(__unused struct vm_io_handler *hdlr,
return val;
}
static void vpic_master_io_write(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width, uint32_t v)
static void vpic_master_io_write(struct vm *vm, uint16_t addr, size_t width,
uint32_t v)
{
uint32_t val = v;
@@ -767,8 +766,7 @@ static int vpic_slave_handler(struct vm *vm, bool in, uint16_t port,
return vpic_write(vpic, i8259, port, eax);
}
static uint32_t vpic_slave_io_read(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width)
static uint32_t vpic_slave_io_read(struct vm *vm, uint16_t addr, size_t width)
{
uint32_t val = 0U;
@@ -779,8 +777,8 @@ static uint32_t vpic_slave_io_read(__unused struct vm_io_handler *hdlr,
return val;
}
static void vpic_slave_io_write(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width, uint32_t v)
static void vpic_slave_io_write(struct vm *vm, uint16_t addr, size_t width,
uint32_t v)
{
uint32_t val = v;
@@ -834,8 +832,7 @@ static int vpic_elc_handler(struct vm *vm, bool in, uint16_t port, size_t bytes,
return 0;
}
static uint32_t vpic_elc_io_read(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width)
static uint32_t vpic_elc_io_read(struct vm *vm, uint16_t addr, size_t width)
{
uint32_t val = 0U;
@@ -845,8 +842,8 @@ static uint32_t vpic_elc_io_read(__unused struct vm_io_handler *hdlr,
return val;
}
static void vpic_elc_io_write(__unused struct vm_io_handler *hdlr,
struct vm *vm, uint16_t addr, size_t width, uint32_t v)
static void vpic_elc_io_write(struct vm *vm, uint16_t addr, size_t width,
uint32_t v)
{
uint32_t val = v;

7
hypervisor/dm/vrtc.c
View File

@@ -46,8 +46,7 @@ static uint8_t cmos_get_reg_val(uint8_t addr)
return reg;
}
static uint32_t vrtc_read(__unused struct vm_io_handler *hdlr, struct vm *vm,
uint16_t addr, __unused size_t width)
static uint32_t vrtc_read(struct vm *vm, uint16_t addr, __unused size_t width)
{
uint8_t reg;
uint8_t offset;
@@ -62,8 +61,8 @@ static uint32_t vrtc_read(__unused struct vm_io_handler *hdlr, struct vm *vm,
return reg;
}
static void vrtc_write(__unused struct vm_io_handler *hdlr, struct vm *vm, uint16_t addr,
size_t width, uint32_t value)
static void vrtc_write(struct vm *vm, uint16_t addr, size_t width,
uint32_t value)
{
if (width != 1U)