github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-23 09:47:44 +00:00
Code Issues Projects Releases Wiki Activity

hv: arch: fix 'Unused procedure parameter'

Browse Source 
MISRA-C requires that there should be no unused parameters in
functions.

In some cases, we will keep the unused parameters.
vmexit handler is one example. It is used as function pointer.
Some of the vmexit handlers use the input parameter 'vcpu', some of
them don't. We still need to keep the unused parameters 'vcpu' for
those handlers don't use 'vcpu'.

This patch removes the unused parameters that is not being used
unconditionally.

v1 -> v2:
 * remove the non-implemented API 'vlapic_id_write_handler'

Tracked-On: #861
Signed-off-by: Shiqing Gao <shiqing.gao@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Shiqing Gao
2018-09-25 15:05:15 +08:00
committed by lijinxia
parent 2908f09f88
commit 8787c06d3b
17 changed files with 68 additions and 91 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
hypervisor/include/arch/x86/assign.h
View File

@@ -15,9 +15,8 @@ int ptdev_msix_remap(struct vm *vm, uint16_t virt_bdf,
uint16_t entry_nr, struct ptdev_msi_info *info);
int ptdev_intx_pin_remap(struct vm *vm, uint8_t virt_pin,
enum ptdev_vpin_source vpin_src);
int ptdev_add_intx_remapping(struct vm *vm, __unused uint16_t virt_bdf,
__unused uint16_t phys_bdf, uint8_t virt_pin, uint8_t phys_pin,
bool pic_pin);
int ptdev_add_intx_remapping(struct vm *vm, uint8_t virt_pin, uint8_t phys_pin,
bool pic_pin);
void ptdev_remove_intx_remapping(struct vm *vm, uint8_t virt_pin, bool pic_pin);
int ptdev_add_msix_remapping(struct vm *vm, uint16_t virt_bdf,
uint16_t phys_bdf, uint32_t vector_count);

2
hypervisor/include/arch/x86/cpu.h
View File

@@ -314,7 +314,7 @@ extern struct cpuinfo_x86 boot_cpu_data;
#define MAX_CX_ENTRY (MAX_CSTATE - 1U)
/* Function prototypes */
void cpu_do_idle(__unused uint16_t pcpu_id);
void cpu_do_idle(void);
void cpu_dead(uint16_t pcpu_id);
void trampoline_start16(void);
bool is_apicv_intr_delivery_supported(void);

2
hypervisor/include/arch/x86/guest/vlapic.h
View File

@@ -178,7 +178,7 @@ void vlapic_init(struct acrn_vlapic *vlapic);
void vlapic_reset(struct acrn_vlapic *vlapic);
void vlapic_restore(struct acrn_vlapic *vlapic, struct lapic_regs *regs);
bool vlapic_enabled(struct acrn_vlapic *vlapic);
uint64_t vlapic_apicv_get_apic_access_addr(__unused struct vm *vm);
uint64_t vlapic_apicv_get_apic_access_addr(void);
uint64_t vlapic_apicv_get_apic_page_addr(struct acrn_vlapic *vlapic);
void vlapic_apicv_inject_pir(struct acrn_vlapic *vlapic);
int apic_access_vmexit_handler(struct vcpu *vcpu);

6
hypervisor/include/arch/x86/ioreq.h
View File

@@ -35,12 +35,10 @@ struct vm;
struct vcpu;
typedef
uint32_t (*io_read_fn_t)(struct vm_io_handler *handler, struct vm *vm,
uint16_t port, size_t size);
uint32_t (*io_read_fn_t)(struct vm *vm, uint16_t port, size_t size);
typedef
void (*io_write_fn_t)(struct vm_io_handler *handler, struct vm *vm,
uint16_t port, size_t size, uint32_t val);
void (*io_write_fn_t)(struct vm *vm, uint16_t port, size_t size, uint32_t val);
/* Describes a single IO handler description entry. */
struct vm_io_handler_desc {