github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-09 10:36:03 +00:00
Code Issues Projects Releases Wiki Activity

tools: acrn-crashlog: fix build warnings with gcc8.1.1

Browse Source 
This patch is to fix the build warning with gcc8.1.1. Most of them are
warnings for buffer overflow from snprintf and strncpy.

Signed-off-by: CHEN Gang <gang.c.chen@intel.com>
Reviewed-by: Zhi Jin <zhi.jin@intel.com>
Reviewed-by: Liu, Xinwu <xinwu.liu@intel.com>
Reviewed-by: xiaojin2 <xiaojing.liu@intel.com>
This commit is contained in:
CHEN Gang
2018-07-30 09:43:08 +08:00
committed by lijinxia
parent 6e77a8d5f1
commit 87a4abdd9d
7 changed files with 33 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
tools/acrn-crashlog/acrnprobe/property.c
View File

@@ -47,7 +47,7 @@ static void get_device_id(struct sender_t *sender)
return;
}
ret = file_read_string(MACHINE_ID, guuid, VERSION_SIZE);
ret = file_read_string(MACHINE_ID, guuid, BUILD_VERSION_SIZE);
if (ret <= 0)
LOGE("Could not get mmc id: %d (%s)\n",
ret, strerror(-ret));
@@ -56,7 +56,8 @@ static void get_device_id(struct sender_t *sender)
LOGE("Could not find DeviceId, set it to '%s'\n",
DEVICE_ID_UNKNOWN);
strncpy(guuid, DEVICE_ID_UNKNOWN, strlen(DEVICE_ID_UNKNOWN));
strncpy(guuid, DEVICE_ID_UNKNOWN, UUID_SIZE);
guuid[UUID_SIZE - 1] = '\0';
write:
overwrite_file(loguuid, guuid);
@@ -66,7 +67,7 @@ write:
static int get_buildversion(struct sender_t *sender)
{
int ret;
char lastbuild[VERSION_SIZE];
char lastbuild[BUILD_VERSION_SIZE];
char *logbuildid;
char *currentbuild = gbuildversion;
@@ -84,7 +85,7 @@ static int get_buildversion(struct sender_t *sender)
return ret;
}
ret = file_read_string(logbuildid, lastbuild, VERSION_SIZE);
ret = file_read_string(logbuildid, lastbuild, BUILD_VERSION_SIZE);
if (ret == -ENOENT ||
!ret ||
(ret > 0 && strcmp(currentbuild, lastbuild))) {