github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-24 14:33:38 +00:00
Code Issues Projects Releases Wiki Activity

dm: passthru: fix potential memory leak

Browse Source 
Fix potential memory leakage in some error case handling.

Tracked-On: #2705
Signed-off-by: Binbin Wu <binbin.wu@intel.com>
This commit is contained in:
Binbin Wu 2019-03-08 13:32:21 +08:00 committed by wenlingz
parent 92d75f0dc2
commit 8cd892a4f0
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
devicemodel/hw/pci/passthrough.c
View File

@ -834,7 +834,8 @@ passthru_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
ptdev = calloc(1, sizeof(struct passthru_dev)); ptdev = calloc(1, sizeof(struct passthru_dev));
if (ptdev == NULL) { if (ptdev == NULL) {
warnx("%s: calloc FAIL!", __func__); warnx("%s: calloc FAIL!", __func__);
return -ENOMEM; error = -ENOMEM;
goto done;
} }
ptdev->phys_bdf = PCI_BDF(bus, slot, func); ptdev->phys_bdf = PCI_BDF(bus, slot, func);
@ -844,7 +845,7 @@ passthru_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
error = pciaccess_init(); error = pciaccess_init();
if (error < 0) if (error < 0)
return error; goto done;
error = -ENODEV; error = -ENODEV;
iter = pci_slot_match_iterator_create(NULL); iter = pci_slot_match_iterator_create(NULL);
@ -859,7 +860,7 @@ passthru_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
if (error < 0) { if (error < 0) {
warnx("No physical PCI device %x:%x.%x!", bus, slot, func); warnx("No physical PCI device %x:%x.%x!", bus, slot, func);
return -ENODEV; goto done;
} }
pci_device_probe(ptdev->phys_dev); pci_device_probe(ptdev->phys_dev);
@ -919,7 +920,9 @@ passthru_init(struct vmctx *ctx, struct pci_vdev *dev, char *opts)
error = 0; /* success */ error = 0; /* success */
done: done:
if (error) { if (error) {
free(ptdev); if (ptdev != NULL) {
free(ptdev);
}
vm_unassign_ptdev(ctx, bus, slot, func); vm_unassign_ptdev(ctx, bus, slot, func);
} }
return error; return error;