github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-08-19 16:50:40 +00:00
Code Issues Projects Releases Wiki Activity

hv:add global lock for VM & vCPU management hypercalls

Browse Source 
this patch is to avoid posisble inconsisent states for
 VMs and vCPUs in configuration that  SOS is SMP based
 and Device Model may be multi-threads based.

Tracked-On: #861
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Yonghua Huang 2018-11-12 18:44:48 +08:00 committed by lijinxia
parent 155675350d
commit 91fb441d7a
1 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
hypervisor/arch/x86/guest/vmcall.c
View File

@ -7,6 +7,10 @@
#include <hypervisor.h> #include <hypervisor.h>
#include <hypercall.h> #include <hypercall.h>
static spinlock_t vmm_hypercall_lock = {
.head = 0U,
.tail = 0U,
};
/* /*
* Pass return value to SOS by register rax. * Pass return value to SOS by register rax.
* This function should always return 0 since we shouldn't * This function should always return 0 since we shouldn't
@ -38,7 +42,9 @@ int vmcall_vmexit_handler(struct acrn_vcpu *vcpu)
/* Dispatch the hypercall handler */ /* Dispatch the hypercall handler */
switch (hypcall_id) { switch (hypcall_id) {
case HC_SOS_OFFLINE_CPU: case HC_SOS_OFFLINE_CPU:
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_sos_offline_cpu(vm, param1); ret = hcall_sos_offline_cpu(vm, param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_GET_API_VERSION: case HC_GET_API_VERSION:
ret = hcall_get_api_version(vm, param1); ret = hcall_get_api_version(vm, param1);
@ -50,37 +56,51 @@ int vmcall_vmexit_handler(struct acrn_vcpu *vcpu)
break; break;
case HC_CREATE_VM: case HC_CREATE_VM:
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_create_vm(vm, param1); ret = hcall_create_vm(vm, param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_DESTROY_VM: case HC_DESTROY_VM:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_destroy_vm((uint16_t)param1); ret = hcall_destroy_vm((uint16_t)param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_START_VM: case HC_START_VM:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_start_vm((uint16_t)param1); ret = hcall_start_vm((uint16_t)param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_RESET_VM: case HC_RESET_VM:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_reset_vm((uint16_t)param1); ret = hcall_reset_vm((uint16_t)param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_PAUSE_VM: case HC_PAUSE_VM:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_pause_vm((uint16_t)param1); ret = hcall_pause_vm((uint16_t)param1);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_CREATE_VCPU: case HC_CREATE_VCPU:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_create_vcpu(vm, (uint16_t)param1, param2); ret = hcall_create_vcpu(vm, (uint16_t)param1, param2);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_SET_VCPU_REGS: case HC_SET_VCPU_REGS:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_set_vcpu_regs(vm, (uint16_t)param1, param2); ret = hcall_set_vcpu_regs(vm, (uint16_t)param1, param2);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_SET_IRQLINE: case HC_SET_IRQLINE:
@ -96,7 +116,9 @@ int vmcall_vmexit_handler(struct acrn_vcpu *vcpu)
case HC_SET_IOREQ_BUFFER: case HC_SET_IOREQ_BUFFER:
/* param1: vmid */ /* param1: vmid */
spinlock_obtain(&vmm_hypercall_lock);
ret = hcall_set_ioreq_buffer(vm, (uint16_t)param1, param2); ret = hcall_set_ioreq_buffer(vm, (uint16_t)param1, param2);
spinlock_release(&vmm_hypercall_lock);
break; break;
case HC_NOTIFY_REQUEST_FINISH: case HC_NOTIFY_REQUEST_FINISH: