github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-07-01 01:32:39 +00:00
Code Issues Projects Releases Wiki Activity

Adding tarfile member sanitization to extractall()

Browse Source 
Tracked-On:#6690
This commit is contained in:
TrellixVulnTeam 2022-10-18 09:09:41 +00:00 committed by acrnsi-robot
parent f451f4a120
commit 92e0039542
1 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
misc/config_tools/configurator/packages/configurator/thirdLib/manager.py
View File

@ -59,7 +59,26 @@ def install(library_name, library_install):
assert tar_mode in ['gz', 'bz2', 'xz', 'tar'] assert tar_mode in ['gz', 'bz2', 'xz', 'tar']
print(f'extract: {tar_file}') print(f'extract: {tar_file}')
with tarfile.open(tar_file, 'r') as tar: with tarfile.open(tar_file, 'r') as tar:
tar.extractall(path=step['to'], members=tar) def is_within_directory(directory, target):
abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)
prefix = os.path.commonprefix([abs_directory, abs_target])
return prefix == abs_directory
def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")
tar.extractall(path, members, numeric_owner=numeric_owner)
safe_extract(tar, path=step["to"], members=tar)
print(f'extract: {tar_file} success') print(f'extract: {tar_file} success')
elif step_type == 'remove': elif step_type == 'remove':
remove_path = step['path'] remove_path = step['path']