github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-30 17:22:09 +00:00
Code Issues Projects Releases Wiki Activity

dm: pci: change return type to bool

Browse Source 
Change return type to bool when returning int is not necessary.

Tracked-On: #2902
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
This commit is contained in:
Peter Fang 2019-04-05 02:31:10 -07:00 committed by ACRN System Integration
parent 887d41683b
commit a718fbe860
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
devicemodel/hw/pci/core.c
View File

@ -542,25 +542,25 @@ register_bar(struct pci_vdev *dev, int idx)
} }
/* Are we decoding i/o port accesses for the emulated pci device? */ /* Are we decoding i/o port accesses for the emulated pci device? */
static int static bool
porten(struct pci_vdev *dev) porten(struct pci_vdev *dev)
{ {
uint16_t cmd; uint16_t cmd;
cmd = pci_get_cfgdata16(dev, PCIR_COMMAND); cmd = pci_get_cfgdata16(dev, PCIR_COMMAND);
return (cmd & PCIM_CMD_PORTEN); return (cmd & PCIM_CMD_PORTEN) != 0;
} }
/* Are we decoding memory accesses for the emulated pci device? */ /* Are we decoding memory accesses for the emulated pci device? */
static int static bool
memen(struct pci_vdev *dev) memen(struct pci_vdev *dev)
{ {
uint16_t cmd; uint16_t cmd;
cmd = pci_get_cfgdata16(dev, PCIR_COMMAND); cmd = pci_get_cfgdata16(dev, PCIR_COMMAND);
return (cmd & PCIM_CMD_MEMEN); return (cmd & PCIM_CMD_MEMEN) != 0;
} }
/* /*
@ -572,7 +572,7 @@ memen(struct pci_vdev *dev)
static void static void
update_bar_address(struct pci_vdev *dev, uint64_t addr, int idx, int type) update_bar_address(struct pci_vdev *dev, uint64_t addr, int idx, int type)
{ {
int decode; bool decode;
if (dev->bar[idx].type == PCIBAR_IO) if (dev->bar[idx].type == PCIBAR_IO)
decode = porten(dev); decode = porten(dev);
@ -671,7 +671,7 @@ pci_emul_alloc_pbar(struct pci_vdev *pdi, int idx, uint64_t hostbase,
lobits = PCIM_BAR_MEM_SPACE | PCIM_BAR_MEM_32; lobits = PCIM_BAR_MEM_SPACE | PCIM_BAR_MEM_32;
break; break;
default: default:
printf("pci_emul_alloc_base: invalid bar type %d\n", type); printf("%s: invalid bar type %d\n", __func__, type);
assert(0); assert(0);
} }
@ -703,7 +703,8 @@ pci_emul_alloc_pbar(struct pci_vdev *pdi, int idx, uint64_t hostbase,
void void
pci_emul_free_bars(struct pci_vdev *pdi) pci_emul_free_bars(struct pci_vdev *pdi)
{ {
int i, enabled; int i;
bool enabled;
for (i = 0; i < PCI_BARMAX; i++) { for (i = 0; i < PCI_BARMAX; i++) {
if ((pdi->bar[i].type != PCIBAR_NONE) && if ((pdi->bar[i].type != PCIBAR_NONE) &&