github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-19 12:12:16 +00:00
Code Issues Projects Releases Wiki Activity

hv: hypercall: general fix "Procedure has more than one exit point"

Browse Source 
IEC 61508,ISO 26262 standards highly recommend single-exit rule.

Reduce the count of the "return entries".
Fix the violations which is comply with the cases list below:
1.Function has 2 return entries.
2.The first return entry is used to return the error code of
checking variable whether is valid.

Fix the violations in "if else" format.
V1->V2:
    update the git comment to describe why comply with the
rule(function's return entry should be only one).
V2->V3:
    update the git comment title to give a scope declaration of this
patch.

Tracked-On: #861
Signed-off-by: Huihuang Shi <huihuang.shi@intel.com>
Reviewed-by: Li, Fei1 <fei1.li@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Huihuang Shi 2018-11-26 13:41:26 +08:00 committed by lijinxia
parent b627c2c979
commit a7398e8a2f
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
hypervisor/common/hypercall.c
View File

@ -15,14 +15,17 @@
bool is_hypercall_from_ring0(void) bool is_hypercall_from_ring0(void)
{ {
uint16_t cs_sel; uint16_t cs_sel;
bool ret;
cs_sel = exec_vmread16(VMX_GUEST_CS_SEL); cs_sel = exec_vmread16(VMX_GUEST_CS_SEL);
/* cs_selector[1:0] is CPL */ /* cs_selector[1:0] is CPL */
if ((cs_sel & 0x3U) == 0U) { if ((cs_sel & 0x3U) == 0U) {
return true; ret = true;
} else {
ret = false;
} }
return false; return ret;
} }
/** /**
@ -76,13 +79,16 @@ int32_t hcall_get_api_version(struct acrn_vm *vm, uint64_t param)
version.major_version = HV_API_MAJOR_VERSION; version.major_version = HV_API_MAJOR_VERSION;
version.minor_version = HV_API_MINOR_VERSION; version.minor_version = HV_API_MINOR_VERSION;
int32_t ret;
if (copy_to_gpa(vm, &version, param, sizeof(version)) != 0) { if (copy_to_gpa(vm, &version, param, sizeof(version)) != 0) {
pr_err("%s: Unable copy param to vm\n", __func__); pr_err("%s: Unable copy param to vm\n", __func__);
return -1; ret = -1;
} else {
ret = 0;
} }
return 0; return ret;
} }
/** /**