github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-06-09 02:24:45 +00:00
Code Issues Projects Releases Wiki Activity

tools: acrn-manager: refine the usage of api 'snprintf'

Browse Source 
Return value check for snprintf function

Tracked-On: #1254
Signed-off-by: Tianhua Sun <tianhuax.s.sun@intel.com>
Acked-by: Yan, Like <like.yan@intel.com>
Reviewed-by: Yonghua Huang <yonghua.huang@intel.com>
Reviewed-by: Kaige Fu <kaige.fu@intel.com>
This commit is contained in:
Tianhua Sun
2018-10-26 18:10:35 +08:00
committed by lijinxia
parent 5493804cab
commit af760f8dce
4 changed files with 113 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tools/acrn-manager/acrn_mngr.c
View File

@@ -300,7 +300,10 @@ static int create_new_server(const char *name)
int ret;
char path[128] = { };
snprintf(path, sizeof(path), MNGR_SOCK_FMT, name, getpid());
if (snprintf(path, sizeof(path), MNGR_SOCK_FMT, name, getpid()) >= sizeof(path)) {
printf("WARN: the path is truncated\n");
return -1;
}
mfd = calloc(1, sizeof(*mfd));
if (!mfd) {
@@ -449,7 +452,7 @@ static int connect_to_server(const char *name)
mfd->addr.sun_family = AF_UNIX;
ret = snprintf(mfd->addr.sun_path, sizeof(mfd->addr.sun_path),
"/run/acrn/mngr/%s", s_name);
if ((ret >= 0) && (ret < strlen(s_name)))
if (ret >= sizeof(mfd->addr.sun_path))
printf("WARN: %s is truncated\n", s_name);
ret =