From b332410f0c3f70547341694c9eb4b3f501b5b5b8 Mon Sep 17 00:00:00 2001
From: Yonghua Huang <yonghua.huang@intel.com>
Date: Wed, 4 Jul 2018 23:14:04 +0800
Subject: [PATCH] HV: Fix coding style violation of MISRA in string.c

- update 'strtol_deci()' & 'strtoul_hex()'

Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
---
 hypervisor/lib/string.c | 31 +++++++++++++++++++++++--------
 1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/hypervisor/lib/string.c b/hypervisor/lib/string.c
index d54ad662d..86d48689a 100644
--- a/hypervisor/lib/string.c
+++ b/hypervisor/lib/string.c
@@ -27,13 +27,17 @@ long strtol_deci(const char *nptr)
 	 * Skip white space and pick up leading +/- sign if any.
 	 */
 	do {
-		c = *s++;
+		c = *s;
+		s++;
 	} while (ISSPACE(c));
 	if (c == '-') {
 		neg = 1;
-		c = *s++;
-	} else if (c == '+')
-		c = *s++;
+		c = *s;
+		s++;
+	} else if (c == '+') {
+		c = *s;
+		s++;
+	}
 	/*
 	 * Compute the cutoff value between legal numbers and illegal
 	 * numbers.  That is the largest legal value, divided by the
@@ -54,7 +58,9 @@ long strtol_deci(const char *nptr)
 	cutoff = (neg != 0) ? -(uint64_t)LONG_MIN : LONG_MAX;
 	cutlim = cutoff % (uint64_t)base;
 	cutoff /= (uint64_t)base;
-	for (acc = 0, any = 0;; c = *s++) {
+	acc = 0;
+	any = 0;
+	do {
 		if (c >= '0' && c <= '9')
 			c -= '0';
 		else
@@ -68,7 +74,11 @@ long strtol_deci(const char *nptr)
 			acc *= base;
 			acc += c;
 		}
-	}
+
+		c = *s;
+		s++;
+	} while (true);
+
 	if (any < 0)
 		acc = (neg != 0) ? LONG_MIN : LONG_MAX;
 	else if (neg != 0)
@@ -101,7 +111,9 @@ uint64_t strtoul_hex(const char *nptr)
 
 	cutoff = (uint64_t)ULONG_MAX / (uint64_t)base;
 	cutlim = (uint64_t)ULONG_MAX % (uint64_t)base;
-	for (acc = 0, any = 0;; c = *s++) {
+	acc = 0;
+	any = 0;
+	do {
 		if (c >= '0' && c <= '9')
 			c -= '0';
 		else if (c >= 'A' && c <= 'F')
@@ -119,7 +131,10 @@ uint64_t strtoul_hex(const char *nptr)
 			acc *= base;
 			acc += c;
 		}
-	}
+
+		c = *s;
+		s++;
+	} while (true);
 
 	if (any <= 0)
 		acc = ULONG_MAX;