github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-24 06:29:19 +00:00
Code Issues Projects Releases Wiki Activity

DM USB: xHCI: do not reset DRD role during S3 process

Browse Source 
To reset USB DRD role is one workaround for adb lost issue with xDCI
passthrough which reproduced in S3 stress test.

This workaround will involve the system global reset if xDCI working in
SuperSpeed mode. This is maybe caused by PMC firmware can't graceful
power gate the xDCI during S3 suspend. The current USB DRD driver will
set STATIC switch bits which will cause ungraceful DRD switch, it may
make the xDCI enter a unknown state, then involved this global reset
issue.

BTW, base on latest code base, the adb lost issue can't reproduce even
remove this workaround. So remove the old workaround for above reasons.

Tracked-On: #2557
Signed-off-by: Yu Wang <yu1.wang@intel.com>
Reviewed-by: Xiaoguang Wu <xiaoguang.wu@intel.com>
Acked-by: Yin Fengwei <fengwei.yin@intel.com>
Signed-off-by: Yu Wang <yu1.wang@intel.com>
This commit is contained in:
Yu Wang 2019-02-19 09:23:19 +08:00 committed by wenlingz
parent 22df0249b5
commit b39524e989
1 changed files with 0 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
devicemodel/hw/pci/xhci.c
View File

@ -508,35 +508,6 @@ static struct pci_xhci_option_elem xhci_option_table[] = {
{"cap", pci_xhci_parse_extcap} {"cap", pci_xhci_parse_extcap}
}; };
static void pci_xhci_reset_role(void)
{
int fd, rc;
fd = open(XHCI_NATIVE_DRD_SWITCH_PATH, O_WRONLY);
if (fd < 0) {
UPRINTF(LFTL, "drd native interface open failed\r\n");
return;
}
UPRINTF(LWRN, "write device in the CRS trap\r\n");
rc = write(fd, "host", 4);
if (rc != 4)
UPRINTF(LFTL, "drd 1 native interface write failure %d\r\n", rc);
rc = fsync(fd);
if (rc)
UPRINTF(LFTL, "drd 2 native interface write failure %d\r\n", rc);
usleep(100000);
rc = write(fd, "device", 6);
if (rc != 6)
UPRINTF(LFTL, "drd 3 native interface write failure %d\r\n", rc);
close(fd);
}
static int static int
pci_xhci_get_free_vport(struct pci_xhci_vdev *xdev, pci_xhci_get_free_vport(struct pci_xhci_vdev *xdev,
struct usb_native_devinfo *di) struct usb_native_devinfo *di)
@ -1277,15 +1248,6 @@ pci_xhci_usbcmd_write(struct pci_xhci_vdev *xdev, uint32_t cmd)
if (cmd & XHCI_CMD_CRS) if (cmd & XHCI_CMD_CRS)
if (xdev->pid == XHCI_PCI_DEVICE_ID_INTEL_APL && if (xdev->pid == XHCI_PCI_DEVICE_ID_INTEL_APL &&
xdev->vid == XHCI_PCI_VENDOR_ID_INTEL) xdev->vid == XHCI_PCI_VENDOR_ID_INTEL)
/* This is a workaround for xDCI passthru. The DRD
* role switching is the precondition for the xDCI
* to work properly. And theoritically, this reset
* operation is not neccessary. But currently, due
* to some unknown reason, this operation could help
* xDCI works better.
*/
pci_xhci_reset_role();
cmd &= ~(XHCI_CMD_CSS | XHCI_CMD_CRS); cmd &= ~(XHCI_CMD_CSS | XHCI_CMD_CRS);
return cmd; return cmd;
} }