github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-30 13:05:45 +00:00
Code Issues Projects Releases Wiki Activity

hv: lib: fix "Procedure has more than one exit point"

Browse Source 
IEC 61508,ISO 26262 standards highly recommend single-exit rule.

Reduce the count of the "return entries".
Fix the violations which is comply with the cases list below:
1.Function has 2 return entries.
2.The first return entry is used to return the error code of
checking variable whether is valid.

Fix the violations in "if else" format.

Tracked-On: #861
Signed-off-by: Huihuang Shi <huihuang.shi@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Huihuang Shi
2018-11-29 11:09:40 +08:00
committed by wenlingz
parent 279808b202
commit ba44417d96
2 changed files with 22 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
hypervisor/include/lib/bits.h
View File

@@ -78,11 +78,12 @@ static inline uint16_t fls64(uint64_t value)
{
uint64_t ret = 0UL;
if (value == 0UL) {
return (INVALID_BIT_INDEX);
}
asm volatile("bsrq %1,%0"
ret = (INVALID_BIT_INDEX);
} else {
asm volatile("bsrq %1,%0"
: "=r" (ret)
: "rm" (value));
}
return (uint16_t)ret;
}