From c03bad1fefe7785a4147c8293b0bc656a4b45d8c Mon Sep 17 00:00:00 2001 From: Shiqing Gao Date: Wed, 19 Dec 2018 14:01:27 +0800 Subject: [PATCH] hv: io: fix MISRA-C violations related to style This patch fixes the MISRA-C violations in arch/x86/io.c. * add the required brackets for logical conjunctions * add the required 'else' for 'if ... else if' case Tracked-On: #861 Signed-off-by: Shiqing Gao Acked-by: Eddie Dong --- hypervisor/arch/x86/io.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hypervisor/arch/x86/io.c b/hypervisor/arch/x86/io.c index 6817ea6c1..17c228884 100644 --- a/hypervisor/arch/x86/io.c +++ b/hypervisor/arch/x86/io.c @@ -378,6 +378,8 @@ int32_t pio_instr_vmexit_handler(struct acrn_vcpu *vcpu) emulate_pio_post(vcpu, io_req); } else if (status == IOREQ_PENDING) { status = 0; + } else { + /* do nothing */ } return status; @@ -480,7 +482,7 @@ int32_t register_mmio_emulation_handler(struct acrn_vm *vm, int32_t status = -EINVAL; struct mem_io_node *mmio_node; - if ((vm->hw.created_vcpus > 0U) && vm->hw.vcpu_array[0].launched) { + if ((vm->hw.created_vcpus > 0U) && (vm->hw.vcpu_array[0].launched)) { ASSERT(false, "register mmio handler after vm launched"); return status; }