From c10ac227ccea196e23d74fac53ad9ac0f61d6018 Mon Sep 17 00:00:00 2001
From: "Yang,Yu-chu" <yu-chu.yang@intel.com>
Date: Thu, 29 Jul 2021 13:46:08 -0700
Subject: [PATCH] config-tools: remove unused package and add nosec to
 subprocess

The subprocess module is needed for calling package from python script.
Add #nosec for subprocess module importing.

Tracked-On: #6342
Signed-off-by: Yang,Yu-chu <yu-chu.yang@intel.com>
---
 misc/config_tools/acpi_gen/bin_gen.py                       | 3 ++-
 misc/config_tools/board_config/board_c.py                   | 1 -
 misc/config_tools/board_inspector/cli.py                    | 2 +-
 misc/config_tools/board_inspector/cpuparser/platformbase.py | 2 +-
 misc/config_tools/board_inspector/legacy/acpi.py            | 2 +-
 misc/config_tools/board_inspector/legacy/board_parser.py    | 2 +-
 misc/config_tools/board_inspector/legacy/misc.py            | 1 -
 misc/config_tools/board_inspector/legacy/parser_lib.py      | 2 +-
 misc/config_tools/hv_config/board_defconfig.py              | 2 +-
 misc/config_tools/library/common.py                         | 2 +-
 10 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/misc/config_tools/acpi_gen/bin_gen.py b/misc/config_tools/acpi_gen/bin_gen.py
index 75ed5200f..76f7c0c4b 100644
--- a/misc/config_tools/acpi_gen/bin_gen.py
+++ b/misc/config_tools/acpi_gen/bin_gen.py
@@ -6,7 +6,8 @@
 """
 
 import logging
-import os, sys, subprocess, argparse, re, shutil
+import subprocess # nosec
+import os, sys, argparse, re, shutil
 sys.path.append(os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', 'board_inspector'))
 import lxml.etree
 from acpi_const import *
diff --git a/misc/config_tools/board_config/board_c.py b/misc/config_tools/board_config/board_c.py
index fca385a07..9cf5b96a9 100644
--- a/misc/config_tools/board_config/board_c.py
+++ b/misc/config_tools/board_config/board_c.py
@@ -5,7 +5,6 @@
 
 import sys
 import enum
-import subprocess
 import board_cfg_lib
 import common
 
diff --git a/misc/config_tools/board_inspector/cli.py b/misc/config_tools/board_inspector/cli.py
index e1d723064..41ccdb21a 100755
--- a/misc/config_tools/board_inspector/cli.py
+++ b/misc/config_tools/board_inspector/cli.py
@@ -7,7 +7,7 @@
 
 import sys, os
 import logging
-import subprocess
+import subprocess # nosec
 import lxml.etree
 import argparse
 from importlib import import_module
diff --git a/misc/config_tools/board_inspector/cpuparser/platformbase.py b/misc/config_tools/board_inspector/cpuparser/platformbase.py
index e7e859330..48ce3d027 100644
--- a/misc/config_tools/board_inspector/cpuparser/platformbase.py
+++ b/misc/config_tools/board_inspector/cpuparser/platformbase.py
@@ -6,7 +6,7 @@
 """Base classes and infrastructure for CPUID and MSR decoding"""
 
 from __future__ import print_function
-import subprocess
+import subprocess # nosec
 import re
 import functools
 import inspect
diff --git a/misc/config_tools/board_inspector/legacy/acpi.py b/misc/config_tools/board_inspector/legacy/acpi.py
index 8c89da8ec..abc5c1513 100644
--- a/misc/config_tools/board_inspector/legacy/acpi.py
+++ b/misc/config_tools/board_inspector/legacy/acpi.py
@@ -5,7 +5,7 @@
 
 import os
 import sys
-import subprocess
+import subprocess # nosec
 import shutil
 from collections import defaultdict
 import dmar
diff --git a/misc/config_tools/board_inspector/legacy/board_parser.py b/misc/config_tools/board_inspector/legacy/board_parser.py
index 698c5682e..892ebf38d 100755
--- a/misc/config_tools/board_inspector/legacy/board_parser.py
+++ b/misc/config_tools/board_inspector/legacy/board_parser.py
@@ -7,7 +7,7 @@ import os
 import sys
 import shutil
 import argparse
-import subprocess
+import subprocess # nosec
 import pci_dev
 import dmi
 import acpi
diff --git a/misc/config_tools/board_inspector/legacy/misc.py b/misc/config_tools/board_inspector/legacy/misc.py
index f24ae8176..3cffc07d7 100644
--- a/misc/config_tools/board_inspector/legacy/misc.py
+++ b/misc/config_tools/board_inspector/legacy/misc.py
@@ -4,7 +4,6 @@
 #
 
 import parser_lib
-import subprocess
 
 MEM_PATH = ['/proc/iomem', '/proc/meminfo']
 TTY_PATH = '/sys/class/tty/'
diff --git a/misc/config_tools/board_inspector/legacy/parser_lib.py b/misc/config_tools/board_inspector/legacy/parser_lib.py
index cbc009715..41ff67d2b 100644
--- a/misc/config_tools/board_inspector/legacy/parser_lib.py
+++ b/misc/config_tools/board_inspector/legacy/parser_lib.py
@@ -4,7 +4,7 @@
 #
 
 import os
-import subprocess
+import subprocess # nosec
 
 BIOS_INFO_KEY = ['BIOS Information', 'Vendor:', 'Version:', 'Release Date:', 'BIOS Revision:']
 
diff --git a/misc/config_tools/hv_config/board_defconfig.py b/misc/config_tools/hv_config/board_defconfig.py
index bbd6ba484..04a9efc4f 100644
--- a/misc/config_tools/hv_config/board_defconfig.py
+++ b/misc/config_tools/hv_config/board_defconfig.py
@@ -4,7 +4,7 @@
 #
 
 import sys
-import subprocess
+import subprocess # nosec
 import board_cfg_lib, scenario_cfg_lib
 import hv_cfg_lib
 import common
diff --git a/misc/config_tools/library/common.py b/misc/config_tools/library/common.py
index aaa055f54..7e9c9720f 100644
--- a/misc/config_tools/library/common.py
+++ b/misc/config_tools/library/common.py
@@ -7,7 +7,7 @@ import os
 import sys
 import getopt
 import shutil
-import subprocess
+import subprocess # nosec
 import xml.etree.ElementTree as ET
 import re
 import lxml