From c52afb145221f7faafdeebd93c33a4666dc8b901 Mon Sep 17 00:00:00 2001 From: "Li, Fei1" Date: Tue, 19 Jun 2018 14:29:20 +0800 Subject: [PATCH] hv: fix error use of list_del for delete timer We should use list_del_init here. Otherwise it would misorder the timer list if we would delete timer more than once if there're more than one timer on it. Change-Id: I2d18248173ced1ea1b723352327d2c3d0efc4900 Signed-off-by: Li, Fei1 --- hypervisor/arch/x86/timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hypervisor/arch/x86/timer.c b/hypervisor/arch/x86/timer.c index 8a586e5b0..df36d9980 100644 --- a/hypervisor/arch/x86/timer.c +++ b/hypervisor/arch/x86/timer.c @@ -96,7 +96,7 @@ int add_timer(struct timer *timer) void del_timer(struct timer *timer) { if (timer && !list_empty(&timer->node)) - list_del(&timer->node); + list_del_init(&timer->node); } static int request_timer_irq(int pcpu_id,