github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-19 20:22:46 +00:00
Code Issues Projects Releases Wiki Activity

hv: vlapic: properly initialize DCR

Browse Source 
DCR is initialized to 0 which means divisor shift is 1. Currently, both
are initialized to 0 which result in incorrect APIC timer counts if the
vLAPIC's DCR is never programmed.

This bug was exposed by OVMF because OVMF does not program DCR during
LAPIC initialization.

Tracked-On: #2543
Signed-off-by: Peter Fang <peter.fang@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Peter Fang 2019-02-15 15:14:34 -08:00 committed by wenlingz
parent 614b2ea816
commit caab595ed4
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hypervisor/arch/x86/guest/vlapic.c
View File

@ -1758,6 +1758,7 @@ vlapic_reset(struct acrn_vlapic *vlapic)
lapic->icr_timer.v = 0U; lapic->icr_timer.v = 0U;
lapic->dcr_timer.v = 0U; lapic->dcr_timer.v = 0U;
vlapic_dcr_write_handler(vlapic);
vlapic_reset_timer(vlapic); vlapic_reset_timer(vlapic);
vlapic->svr_last = lapic->svr.v; vlapic->svr_last = lapic->svr.v;
@ -1809,6 +1810,7 @@ void vlapic_restore(struct acrn_vlapic *vlapic, const struct lapic_regs *regs)
lapic->icr_timer = regs->icr_timer; lapic->icr_timer = regs->icr_timer;
lapic->ccr_timer = regs->ccr_timer; lapic->ccr_timer = regs->ccr_timer;
lapic->dcr_timer = regs->dcr_timer; lapic->dcr_timer = regs->dcr_timer;
vlapic_dcr_write_handler(vlapic);
} }
static uint64_t static uint64_t