github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-22 13:37:10 +00:00
Code Issues Projects Releases Wiki Activity

hv: fix MISRA-C violations "Pointer param should be declared pointer to const."

Browse Source 
MIRSA-C requires the const qualifier should be applied to pointer parameters
that address data not subject to change in rule 120D.

Tracked-On #861
Signed-off-by: Zide Chen <zide.chen@intel.com>
Acked-by: Anthony Xu <anthony.xu@intel.com>
This commit is contained in:
Zide Chen 2018-12-14 11:55:06 -08:00 committed by wenlingz
parent f81fb21a58
commit d133f95d97
10 changed files with 27 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hypervisor/arch/x86/guest/vmsr.c
View File

@ -547,7 +547,7 @@ int32_t wrmsr_vmexit_handler(struct acrn_vcpu *vcpu)
return err; return err;
} }
void update_msr_bitmap_x2apic_apicv(struct acrn_vcpu *vcpu) void update_msr_bitmap_x2apic_apicv(const struct acrn_vcpu *vcpu)
{ {
uint8_t *msr_bitmap; uint8_t *msr_bitmap;
@ -576,7 +576,7 @@ void update_msr_bitmap_x2apic_apicv(struct acrn_vcpu *vcpu)
} }
} }
void update_msr_bitmap_x2apic_passthru(struct acrn_vcpu *vcpu) void update_msr_bitmap_x2apic_passthru(const struct acrn_vcpu *vcpu)
{ {
uint32_t msr; uint32_t msr;
uint8_t *msr_bitmap; uint8_t *msr_bitmap;

2
hypervisor/dm/vpci/core.c
View File

@ -30,7 +30,7 @@
#include <hypervisor.h> #include <hypervisor.h>
#include "pci_priv.h" #include "pci_priv.h"
uint32_t pci_vdev_read_cfg(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes) uint32_t pci_vdev_read_cfg(const struct pci_vdev *vdev, uint32_t offset, uint32_t bytes)
{ {
uint32_t val; uint32_t val;

2
hypervisor/dm/vpci/hostbridge.c
View File

@ -89,7 +89,7 @@ static int32_t vdev_hostbridge_deinit(__unused struct pci_vdev *vdev)
return 0; return 0;
} }
static int32_t vdev_hostbridge_cfgread(struct pci_vdev *vdev, uint32_t offset, static int32_t vdev_hostbridge_cfgread(const struct pci_vdev *vdev, uint32_t offset,
uint32_t bytes, uint32_t *val) uint32_t bytes, uint32_t *val)
{ {
/* Assumption: access needed to be aligned on 1/2/4 bytes */ /* Assumption: access needed to be aligned on 1/2/4 bytes */

6
hypervisor/dm/vpci/msi.c
View File

@ -30,7 +30,7 @@
#include <hypervisor.h> #include <hypervisor.h>
#include "pci_priv.h" #include "pci_priv.h"
static inline bool msicap_access(struct pci_vdev *vdev, uint32_t offset) static inline bool msicap_access(const struct pci_vdev *vdev, uint32_t offset)
{ {
bool ret; bool ret;
if (vdev->msi.capoff == 0U) { if (vdev->msi.capoff == 0U) {
@ -42,7 +42,7 @@ static inline bool msicap_access(struct pci_vdev *vdev, uint32_t offset)
return ret; return ret;
} }
static int32_t vmsi_remap(struct pci_vdev *vdev, bool enable) static int32_t vmsi_remap(const struct pci_vdev *vdev, bool enable)
{ {
struct ptirq_msi_info info; struct ptirq_msi_info info;
union pci_bdf pbdf = vdev->pdev.bdf; union pci_bdf pbdf = vdev->pdev.bdf;
@ -99,7 +99,7 @@ static int32_t vmsi_remap(struct pci_vdev *vdev, bool enable)
return ret; return ret;
} }
static int32_t vmsi_cfgread(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t *val) static int32_t vmsi_cfgread(const struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t *val)
{ {
int32_t ret; int32_t ret;
/* For PIO access, we emulate Capability Structures only */ /* For PIO access, we emulate Capability Structures only */

14
hypervisor/dm/vpci/msix.c
View File

@ -30,7 +30,7 @@
#include <hypervisor.h> #include <hypervisor.h>
#include "pci_priv.h" #include "pci_priv.h"
static inline bool msixcap_access(struct pci_vdev *vdev, uint32_t offset) static inline bool msixcap_access(const struct pci_vdev *vdev, uint32_t offset)
{ {
bool ret; bool ret;
@ -43,12 +43,12 @@ static inline bool msixcap_access(struct pci_vdev *vdev, uint32_t offset)
return ret; return ret;
} }
static inline bool msixtable_access(struct pci_vdev *vdev, uint32_t offset) static inline bool msixtable_access(const struct pci_vdev *vdev, uint32_t offset)
{ {
return in_range(offset, vdev->msix.table_offset, vdev->msix.table_count * MSIX_TABLE_ENTRY_SIZE); return in_range(offset, vdev->msix.table_offset, vdev->msix.table_count * MSIX_TABLE_ENTRY_SIZE);
} }
static int32_t vmsix_remap_entry(struct pci_vdev *vdev, uint32_t index, bool enable) static int32_t vmsix_remap_entry(const struct pci_vdev *vdev, uint32_t index, bool enable)
{ {
struct msix_table_entry *pentry; struct msix_table_entry *pentry;
struct ptirq_msi_info info; struct ptirq_msi_info info;
@ -82,7 +82,7 @@ static int32_t vmsix_remap_entry(struct pci_vdev *vdev, uint32_t index, bool ena
return ret; return ret;
} }
static inline void enable_disable_msix(struct pci_vdev *vdev, bool enable) static inline void enable_disable_msix(const struct pci_vdev *vdev, bool enable)
{ {
uint32_t msgctrl; uint32_t msgctrl;
@ -96,7 +96,7 @@ static inline void enable_disable_msix(struct pci_vdev *vdev, bool enable)
} }
/* Do MSI-X remap for all MSI-X table entries in the target device */ /* Do MSI-X remap for all MSI-X table entries in the target device */
static int32_t vmsix_remap(struct pci_vdev *vdev, bool enable) static int32_t vmsix_remap(const struct pci_vdev *vdev, bool enable)
{ {
uint32_t index; uint32_t index;
int32_t ret = 0; int32_t ret = 0;
@ -123,7 +123,7 @@ static int32_t vmsix_remap(struct pci_vdev *vdev, bool enable)
} }
/* Do MSI-X remap for one MSI-X table entry only */ /* Do MSI-X remap for one MSI-X table entry only */
static int32_t vmsix_remap_one_entry(struct pci_vdev *vdev, uint32_t index, bool enable) static int32_t vmsix_remap_one_entry(const struct pci_vdev *vdev, uint32_t index, bool enable)
{ {
uint32_t msgctrl; uint32_t msgctrl;
int32_t ret; int32_t ret;
@ -148,7 +148,7 @@ static int32_t vmsix_remap_one_entry(struct pci_vdev *vdev, uint32_t index, bool
return ret; return ret;
} }
static int32_t vmsix_cfgread(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t *val) static int32_t vmsix_cfgread(const struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t *val)
{ {
int32_t ret; int32_t ret;
/* For PIO access, we emulate Capability Structures only */ /* For PIO access, we emulate Capability Structures only */

8
hypervisor/dm/vpci/pci_priv.h
View File

@ -37,17 +37,17 @@ static inline bool in_range(uint32_t value, uint32_t lower, uint32_t len)
return ((value >= lower) && (value < (lower + len))); return ((value >= lower) && (value < (lower + len)));
} }
static inline uint8_t pci_vdev_read_cfg_u8(struct pci_vdev *vdev, uint32_t offset) static inline uint8_t pci_vdev_read_cfg_u8(const struct pci_vdev *vdev, uint32_t offset)
{ {
return vdev->cfgdata.data_8[offset]; return vdev->cfgdata.data_8[offset];
} }
static inline uint16_t pci_vdev_read_cfg_u16(struct pci_vdev *vdev, uint32_t offset) static inline uint16_t pci_vdev_read_cfg_u16(const struct pci_vdev *vdev, uint32_t offset)
{ {
return vdev->cfgdata.data_16[offset >> 1U]; return vdev->cfgdata.data_16[offset >> 1U];
} }
static inline uint32_t pci_vdev_read_cfg_u32(struct pci_vdev *vdev, uint32_t offset) static inline uint32_t pci_vdev_read_cfg_u32(const struct pci_vdev *vdev, uint32_t offset)
{ {
return vdev->cfgdata.data_32[offset >> 2U]; return vdev->cfgdata.data_32[offset >> 2U];
} }
@ -74,7 +74,7 @@ extern const struct vpci_ops sharing_mode_vpci_ops;
extern const struct pci_vdev_ops pci_ops_vdev_msix; extern const struct pci_vdev_ops pci_ops_vdev_msix;
#endif #endif
uint32_t pci_vdev_read_cfg(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes); uint32_t pci_vdev_read_cfg(const struct pci_vdev *vdev, uint32_t offset, uint32_t bytes);
void pci_vdev_write_cfg(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t val); void pci_vdev_write_cfg(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t val);
void populate_msi_struct(struct pci_vdev *vdev); void populate_msi_struct(struct pci_vdev *vdev);

2
hypervisor/dm/vpci/pci_pt.c
View File

@ -97,7 +97,7 @@ static int32_t vdev_pt_deinit(struct pci_vdev *vdev)
return ret; return ret;
} }
static int32_t vdev_pt_cfgread(struct pci_vdev *vdev, uint32_t offset, static int32_t vdev_pt_cfgread(const struct pci_vdev *vdev, uint32_t offset,
uint32_t bytes, uint32_t *val) uint32_t bytes, uint32_t *val)
{ {
/* Assumption: access needed to be aligned on 1/2/4 bytes */ /* Assumption: access needed to be aligned on 1/2/4 bytes */

6
hypervisor/dm/vpci/sharing_mode.c
View File

@ -200,7 +200,7 @@ const struct vpci_ops sharing_mode_vpci_ops = {
.cfgwrite = sharing_mode_cfgwrite, .cfgwrite = sharing_mode_cfgwrite,
}; };
void vpci_set_ptdev_intr_info(struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf) void vpci_set_ptdev_intr_info(const struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf)
{ {
struct pci_vdev *vdev; struct pci_vdev *vdev;
@ -210,13 +210,13 @@ void vpci_set_ptdev_intr_info(struct acrn_vm *target_vm, uint16_t vbdf, uint16_t
target_vm->vm_id, vbdf, pbdf); target_vm->vm_id, vbdf, pbdf);
} else { } else {
/* UOS may do BDF mapping */ /* UOS may do BDF mapping */
vdev->vpci = &target_vm->vpci; vdev->vpci = (struct acrn_vpci *)&(target_vm->vpci);
vdev->vbdf.value = vbdf; vdev->vbdf.value = vbdf;
vdev->pdev.bdf.value = pbdf; vdev->pdev.bdf.value = pbdf;
} }
} }
void vpci_reset_ptdev_intr_info(struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf) void vpci_reset_ptdev_intr_info(const struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf)
{ {
struct pci_vdev *vdev; struct pci_vdev *vdev;
struct acrn_vm *vm; struct acrn_vm *vm;

4
hypervisor/include/arch/x86/guest/guest.h
View File

@ -104,8 +104,8 @@ void init_msr_emulation(struct acrn_vcpu *vcpu);
uint32_t vmsr_get_guest_msr_index(uint32_t msr); uint32_t vmsr_get_guest_msr_index(uint32_t msr);
void update_msr_bitmap_x2apic_apicv(struct acrn_vcpu *vcpu); void update_msr_bitmap_x2apic_apicv(const struct acrn_vcpu *vcpu);
void update_msr_bitmap_x2apic_passthru(struct acrn_vcpu *vcpu); void update_msr_bitmap_x2apic_passthru(const struct acrn_vcpu *vcpu);
struct run_context; struct run_context;
int32_t vmx_vmrun(struct run_context *context, int32_t ops, int32_t ibrs); int32_t vmx_vmrun(struct run_context *context, int32_t ops, int32_t ibrs);

6
hypervisor/include/dm/vpci.h
View File

@ -41,7 +41,7 @@ struct pci_vdev_ops {
int32_t (*cfgwrite)(struct pci_vdev *vdev, uint32_t offset, int32_t (*cfgwrite)(struct pci_vdev *vdev, uint32_t offset,
uint32_t bytes, uint32_t val); uint32_t bytes, uint32_t val);
int32_t (*cfgread)(struct pci_vdev *vdev, uint32_t offset, int32_t (*cfgread)(const struct pci_vdev *vdev, uint32_t offset,
uint32_t bytes, uint32_t *val); uint32_t bytes, uint32_t *val);
}; };
@ -147,7 +147,7 @@ extern const struct pci_vdev_ops pci_ops_vdev_pt;
void vpci_init(struct acrn_vm *vm); void vpci_init(struct acrn_vm *vm);
void vpci_cleanup(struct acrn_vm *vm); void vpci_cleanup(struct acrn_vm *vm);
void vpci_set_ptdev_intr_info(struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf); void vpci_set_ptdev_intr_info(const struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf);
void vpci_reset_ptdev_intr_info(struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf); void vpci_reset_ptdev_intr_info(const struct acrn_vm *target_vm, uint16_t vbdf, uint16_t pbdf);
#endif /* VPCI_H_ */ #endif /* VPCI_H_ */