github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-05-08 16:36:58 +00:00
Code Issues Projects Releases Wiki Activity

dm: virtio: make sure VQ_ALLOC is set after initialization

Browse Source 
Make sure VQ_ALLOC is visible only after vq is completely initialized.

This ensures vq_ring_ready() is reliable when it returns true.

Tracked-On: #2763
Signed-off-by: Peter Fang <peter.fang@intel.com>
Reviewed-by: Shuo A Liu <shuo.a.liu@intel.com>
This commit is contained in:
Peter Fang 2019-03-17 02:02:52 -07:00 committed by wenlingz
parent 6be9f15aa6
commit d38afa6f48
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
devicemodel/hw/pci/virtio/virtio.c
View File

@ -304,10 +304,13 @@ virtio_vq_init(struct virtio_base *base, uint32_t pfn)
/* ... and the last page(s) are the used ring. */ /* ... and the last page(s) are the used ring. */
vq->used = (struct vring_used *)vb; vq->used = (struct vring_used *)vb;
/* Mark queue as allocated, and start at 0 when we use it. */ /* Start at 0 when we use it. */
vq->flags = VQ_ALLOC;
vq->last_avail = 0; vq->last_avail = 0;
vq->save_used = 0; vq->save_used = 0;
/* Mark queue as allocated after initialization is complete. */
mb();
vq->flags = VQ_ALLOC;
} }
/* /*
@ -346,13 +349,16 @@ virtio_vq_enable(struct virtio_base *base)
vb = paddr_guest2host(base->dev->vmctx, phys, size); vb = paddr_guest2host(base->dev->vmctx, phys, size);
vq->used = (struct vring_used *)vb; vq->used = (struct vring_used *)vb;
/* Mark queue as allocated, and start at 0 when we use it. */ /* Start at 0 when we use it. */
vq->flags = VQ_ALLOC;
vq->last_avail = 0; vq->last_avail = 0;
vq->save_used = 0; vq->save_used = 0;
/* Mark queue as enabled. */ /* Mark queue as enabled. */
vq->enabled = true; vq->enabled = true;
/* Mark queue as allocated after initialization is complete. */
mb();
vq->flags = VQ_ALLOC;
} }
/* /*