github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-22 09:17:58 +00:00
Code Issues Projects Releases Wiki Activity

HV: Moving operators out from conditions

Browse Source 
To follow the Misra-c standard, any operators should be done outside
the conditions. Removed the prefix, postfix and bitwise shift from
conditions.

Signed-off-by: Yang, Yu-chu <yu-chu.yang@intel.com>
This commit is contained in:
Yang, Yu-chu
2018-06-26 17:30:41 -07:00
committed by lijinxia
parent 078178b23b
commit dd695f3cfa
10 changed files with 41 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
hypervisor/lib/div.c
View File

@@ -27,7 +27,8 @@ static int do_udiv32(uint32_t dividend, uint32_t divisor,
res->q.dwords.low |= mask;
}
divisor >>= 1U;
} while (((mask >>= 1U) != 0U) && (dividend != 0U));
mask >>= 1U;
} while ((mask != 0U) && (dividend != 0U));
/* dividend now contains the reminder */
res->r.dwords.low = dividend;
return 0;

3
hypervisor/lib/mdelay.c
View File

@@ -9,8 +9,9 @@
void mdelay(uint32_t loop_count)
{
/* Loop until done */
while (loop_count-- != 0) {
while (loop_count != 0) {
/* Delay for 1 ms */
udelay(1000);
loop_count--;
}
}

14
hypervisor/lib/memory.c
View File

@@ -95,11 +95,13 @@ static void *allocate_mem(struct mem_pool *pool, unsigned int num_bytes)
*/
for (i = 1; i < requested_buffs; i++) {
/* Check if tmp_bit_idx is out-of-range */
if (++tmp_bit_idx == BITMAP_WORD_SIZE) {
tmp_bit_idx++;
if (tmp_bit_idx == BITMAP_WORD_SIZE) {
/* Break the loop if tmp_idx is
* out-of-range
*/
if (++tmp_idx == pool->bmp_size)
tmp_idx++;
if (tmp_idx == pool->bmp_size)
break;
/* Reset tmp_bit_idx */
tmp_bit_idx = 0U;
@@ -153,7 +155,8 @@ static void *allocate_mem(struct mem_pool *pool, unsigned int num_bytes)
}
/* Check if bit_idx is out-of-range */
if (++bit_idx == BITMAP_WORD_SIZE) {
bit_idx++;
if (bit_idx == BITMAP_WORD_SIZE) {
/* Increment idx */
idx++;
/* Reset bit_idx */
@@ -306,8 +309,9 @@ void *memchr(const void *void_s, int c, size_t n)
while (ptr < end) {
if (*ptr++ == val)
return ((void *)(ptr - 1));
if (*ptr == val)
return ((void *)ptr);
ptr++;
}
return NULL;

18
hypervisor/lib/sprintf.c
View File

@@ -147,7 +147,8 @@ static const char *get_length_modifier(const char *s,
{
/* check for h[h] (char/short) */
if (*s == 'h') {
if (*++s == 'h') {
s++;
if (*s == 'h') {
*flags |= PRINT_FLAG_CHAR;
*mask = 0x000000FF;
++s;
@@ -158,7 +159,8 @@ static const char *get_length_modifier(const char *s,
}
/* check for l[l] (long/long long) */
else if (*s == 'l') {
if (*++s == 'l') {
s++;
if (*s == 'l') {
*flags |= PRINT_FLAG_LONG_LONG;
++s;
} else
@@ -297,8 +299,10 @@ static int print_pow2(struct print_param *param,
/* determine digits from right to left */
do {
*--pos = digits[(v & mask)];
} while ((v >>= shift) != 0UL);
pos--;
*pos = digits[(v & mask)];
v >>= shift;
} while (v != 0UL);
/* assign parameter and apply width and precision */
param->vars.value = pos;
@@ -365,8 +369,10 @@ static int print_decimal(struct print_param *param, int64_t value)
* 10.
*/
nv.dwords.low = v.dwords.low / 10;
*--pos = (v.dwords.low - (10 * nv.dwords.low)) + '0';
} while ((v.dwords.low = nv.dwords.low) != 0);
pos--;
*pos = (v.dwords.low - (10 * nv.dwords.low)) + '0';
v.dwords.low = nv.dwords.low;
} while (v.dwords.low != 0);
/* assign parameter and apply width and precision */
param->vars.value = pos;