github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2026-01-06 08:04:55 +00:00
Code Issues Projects Releases Wiki Activity

hv:fix "missing for discarded return value" for memcpy_s and strcpy_s

Browse Source 
It will print error information inside memcpy_s if
the parameteter is invalid, the caller can not check
the return value for memcpy_s/strcpy_s/strncpy_s
code like this:
int a(void) {
return 0;
}
int b(void){
a();
}
fix as follow:
int a(void) {
return 0;
}
int b(void){
(void)a();
}

Signed-off-by: Mingqiang Chi <mingqiang.chi@intel.com>
This commit is contained in:
Mingqiang Chi
2018-07-05 13:32:01 +08:00
committed by wenlingz
parent 8d3847d216
commit deb44402e3
20 changed files with 63 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
hypervisor/debug/shell_internal.c
View File

@@ -306,7 +306,7 @@ int shell_process_cmd(struct shell *p_shell, char *p_input_line)
/* Copy the input line INTo an argument string to become part of the
* argument vector.
*/
(void) strcpy_s(&cmd_argv_str[0], SHELL_CMD_MAX_LEN, p_input_line);
(void)strcpy_s(&cmd_argv_str[0], SHELL_CMD_MAX_LEN, p_input_line);
cmd_argv_str[SHELL_CMD_MAX_LEN] = 0;
/* Build the argv vector from the string. The first argument in the
@@ -464,13 +464,13 @@ int shell_list_vm(struct shell *p_shell,
vm = list_entry(pos, struct vm, list);
switch (vm->state) {
case VM_CREATED:
strcpy_s(state, 32, "Created"); break;
(void)strcpy_s(state, 32, "Created"); break;
case VM_STARTED:
strcpy_s(state, 32, "Started"); break;
(void)strcpy_s(state, 32, "Started"); break;
case VM_PAUSED:
strcpy_s(state, 32, "Paused"); break;
(void)strcpy_s(state, 32, "Paused"); break;
default:
strcpy_s(state, 32, "Unknown"); break;
(void)strcpy_s(state, 32, "Unknown"); break;
}
/* Create output string consisting of VM name and VM id
*/
@@ -508,15 +508,15 @@ int shell_list_vcpu(struct shell *p_shell,
foreach_vcpu(i, vm, vcpu) {
switch (vcpu->state) {
case VCPU_INIT:
strcpy_s(state, 32, "Init"); break;
(void)strcpy_s(state, 32, "Init"); break;
case VCPU_PAUSED:
strcpy_s(state, 32, "Paused"); break;
(void)strcpy_s(state, 32, "Paused"); break;
case VCPU_RUNNING:
strcpy_s(state, 32, "Running"); break;
(void)strcpy_s(state, 32, "Running"); break;
case VCPU_ZOMBIE:
strcpy_s(state, 32, "Zombie"); break;
(void)strcpy_s(state, 32, "Zombie"); break;
default:
strcpy_s(state, 32, "Unknown");
(void)strcpy_s(state, 32, "Unknown");
}
/* Create output string consisting of VM name
* and VM id