From e12f88b8c7ca1df85fb88089439485c3c44d1382 Mon Sep 17 00:00:00 2001 From: Jian Jun Chen Date: Sat, 29 Sep 2018 09:14:00 +0800 Subject: [PATCH] dm: virtio-console: remove unused virtio_console_cfgwrite Virtio-console device specific configuration is readonly, callback for the cfgwrite is not required. This patch removed the unused virtio_console_cfgwrite. Tracked-On: #1364 Signed-off-by: Jian Jun Chen Acked-by: Yu Wang --- devicemodel/hw/pci/virtio/virtio_console.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/devicemodel/hw/pci/virtio/virtio_console.c b/devicemodel/hw/pci/virtio/virtio_console.c index 62794b427..03376453f 100644 --- a/devicemodel/hw/pci/virtio/virtio_console.c +++ b/devicemodel/hw/pci/virtio/virtio_console.c @@ -148,7 +148,6 @@ static void virtio_console_reset(void *); static void virtio_console_notify_rx(void *, struct virtio_vq_info *); static void virtio_console_notify_tx(void *, struct virtio_vq_info *); static int virtio_console_cfgread(void *, int, int, uint32_t *); -static int virtio_console_cfgwrite(void *, int, int, uint32_t); static void virtio_console_neg_features(void *, uint64_t); static void virtio_console_control_send(struct virtio_console *, struct virtio_console_control *, const void *, size_t); @@ -162,7 +161,7 @@ static struct virtio_ops virtio_console_ops = { virtio_console_reset, /* reset */ NULL, /* device-wide qnotify */ virtio_console_cfgread, /* read virtio config */ - virtio_console_cfgwrite, /* write virtio config */ + NULL, /* write virtio config */ virtio_console_neg_features, /* apply negotiated features */ NULL, /* called on guest set status */ }; @@ -207,12 +206,6 @@ virtio_console_cfgread(void *vdev, int offset, int size, uint32_t *retval) return 0; } -static int -virtio_console_cfgwrite(void *vdev, int offset, int size, uint32_t val) -{ - return 0; -} - static inline struct virtio_console_port * virtio_console_vq_to_port(struct virtio_console *console, struct virtio_vq_info *vq)