github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-07-02 10:12:25 +00:00
Code Issues Projects Releases Wiki Activity

HV: remove multi returns in vlapic_set_apicbase

Browse Source 
remove few calls to return statement in routines.

Tracked-On: #861
Signed-off-by: Chaohong guo <chaohong.guo@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Chaohong guo 2019-01-03 12:37:43 +08:00 committed by wenlingz
parent 9efbdc829d
commit e2c11c0c75
1 changed files with 22 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
hypervisor/arch/x86/guest/vlapic.c
View File

@ -1767,26 +1767,23 @@ static int32_t
vlapic_set_apicbase(struct acrn_vlapic *vlapic, uint64_t new) vlapic_set_apicbase(struct acrn_vlapic *vlapic, uint64_t new)
{ {
int32_t ret = 0;
uint64_t changed; uint64_t changed;
changed = vlapic->msr_apicbase ^ new; changed = vlapic->msr_apicbase ^ new;
if (changed == APICBASE_X2APIC) { if ((changed == APICBASE_X2APIC) && ((new & APICBASE_X2APIC) == APICBASE_X2APIC)) {
if ((new & APICBASE_X2APIC) == APICBASE_X2APIC) {
vlapic->msr_apicbase = new; vlapic->msr_apicbase = new;
vlapic_build_x2apic_id(vlapic); vlapic_build_x2apic_id(vlapic);
switch_apicv_mode_x2apic(vlapic->vcpu); switch_apicv_mode_x2apic(vlapic->vcpu);
return 0; ret = 0;
} } else if (vlapic->msr_apicbase != new) {
}
if (vlapic->msr_apicbase != new) {
dev_dbg(ACRN_DBG_LAPIC, dev_dbg(ACRN_DBG_LAPIC,
"NOT support to change APIC_BASE MSR from %#lx to %#lx", "NOT support to change APIC_BASE MSR from %#lx to %#lx",
vlapic->msr_apicbase, new); vlapic->msr_apicbase, new);
return (-1); ret = -1;
} }
return 0; return ret;
} }
void void
@ -2461,26 +2458,24 @@ int32_t apic_access_vmexit_handler(struct acrn_vcpu *vcpu)
/* apic access should already fetched instruction, decode_instruction /* apic access should already fetched instruction, decode_instruction
* will not trigger #PF, so if it failed, just return error_no * will not trigger #PF, so if it failed, just return error_no
*/ */
if (err < 0) { if (err >= 0) {
return err;
}
if (access_type == 1UL) { if (access_type == 1UL) {
if (emulate_instruction(vcpu) == 0) { if (emulate_instruction(vcpu) == 0) {
err = vlapic_write(vlapic, offset, mmio->value); err = vlapic_write(vlapic, offset, mmio->value);
} }
} else if (access_type == 0UL) { } else if (access_type == 0UL) {
err = vlapic_read(vlapic, offset, &mmio->value); err = vlapic_read(vlapic, offset, &mmio->value);
if (err < 0) { if (err >= 0) {
return err;
}
err = emulate_instruction(vcpu); err = emulate_instruction(vcpu);
}
} else { } else {
pr_err("Unhandled APIC access type: %lu\n", access_type); pr_err("Unhandled APIC access type: %lu\n", access_type);
err = -EINVAL; err = -EINVAL;
} }
TRACE_2L(TRACE_VMEXIT_APICV_ACCESS, qual, (uint64_t)vlapic); TRACE_2L(TRACE_VMEXIT_APICV_ACCESS, qual, (uint64_t)vlapic);
}
return err; return err;
} }