github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-24 14:33:38 +00:00
Code Issues Projects Releases Wiki Activity

HV: ioapic: clean up remaining integral-related violations

Browse Source 
This patch cleans up the remaining integral-related violations in ioapic.c,
including

    * integral narrowing, and
    * explicit conversion between signed & unsigned integers.

Tracked-on: ccm0001001-247033
Signed-off-by: Junjie Mao <junjie.mao@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Junjie Mao 2018-07-06 20:59:44 +08:00 committed by lijinxia
parent c477138f19
commit e6499674fd
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
hypervisor/arch/x86/ioapic.c
View File

@ -262,8 +262,8 @@ void ioapic_set_rte(uint32_t irq, uint64_t raw_rte)
return; return;
addr = gsi_table[irq].addr; addr = gsi_table[irq].addr;
rte.lo_32 = raw_rte; rte.lo_32 = (uint32_t)raw_rte;
rte.hi_32 = raw_rte >> 32; rte.hi_32 = (uint32_t)(raw_rte >> 32);
ioapic_set_rte_entry(addr, gsi_table[irq].pin, &rte); ioapic_set_rte_entry(addr, gsi_table[irq].pin, &rte);
dev_dbg(ACRN_DBG_IRQ, "GSI: irq:%d pin:%hhu rte:%x", dev_dbg(ACRN_DBG_IRQ, "GSI: irq:%d pin:%hhu rte:%x",
@ -445,7 +445,7 @@ void resume_ioapic(void)
#ifdef HV_DEBUG #ifdef HV_DEBUG
void get_rte_info(struct ioapic_rte *rte, bool *mask, bool *irr, void get_rte_info(struct ioapic_rte *rte, bool *mask, bool *irr,
bool *phys, int *delmode, bool *level, int *vector, uint32_t *dest) bool *phys, uint32_t *delmode, bool *level, uint32_t *vector, uint32_t *dest)
{ {
*mask = ((rte->lo_32 & IOAPIC_RTE_INTMASK) == IOAPIC_RTE_INTMSET); *mask = ((rte->lo_32 & IOAPIC_RTE_INTMASK) == IOAPIC_RTE_INTMSET);
*irr = ((rte->lo_32 & IOAPIC_RTE_REM_IRR) == IOAPIC_RTE_REM_IRR); *irr = ((rte->lo_32 & IOAPIC_RTE_REM_IRR) == IOAPIC_RTE_REM_IRR);
@ -472,8 +472,7 @@ int get_ioapic_info(char *str, int str_max_len)
struct ioapic_rte rte; struct ioapic_rte rte;
bool irr, phys, level, mask; bool irr, phys, level, mask;
int delmode, vector; uint32_t delmode, vector, dest;
uint32_t dest;
ioapic_get_rte_entry(addr, pin, &rte); ioapic_get_rte_entry(addr, pin, &rte);
@ -485,7 +484,7 @@ int get_ioapic_info(char *str, int str_max_len)
size -= len; size -= len;
str += len; str += len;
len = snprintf(str, size, "0x%02X\t0x%02X\t%s\t%s\t%d\t%d\t%d", len = snprintf(str, size, "0x%02X\t0x%02X\t%s\t%s\t%u\t%d\t%d",
vector, dest, phys ? "phys" : "logic", vector, dest, phys ? "phys" : "logic",
level ? "level" : "edge", delmode >> 8, irr, mask); level ? "level" : "edge", delmode >> 8, irr, mask);
size -= len; size -= len;