github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-20 20:53:46 +00:00
Code Issues Projects Releases Wiki Activity

hv: assign: fix MISRA-C violations on potential null pointer deference

Browse Source 
This patch fix the MISRA-C violations in arch/x86/assign.c
on potential null pointer deference.
Also add a break in case statement.

Tracked-On: #861
Signed-off-by: Binbin Wu <binbin.wu@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
This commit is contained in:
Binbin Wu 2018-12-18 21:08:19 +08:00 committed by wenlingz
parent e19dcf5735
commit e8b3e44fc0
1 changed files with 11 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hypervisor/arch/x86/assign.c
View File

@ -17,7 +17,7 @@
*/ */
static inline struct ptirq_remapping_info * static inline struct ptirq_remapping_info *
ptirq_lookup_entry_by_sid(uint32_t intr_type, ptirq_lookup_entry_by_sid(uint32_t intr_type,
const union source_id *sid,const struct acrn_vm *vm) const union source_id *sid, const struct acrn_vm *vm)
{ {
uint16_t idx; uint16_t idx;
struct ptirq_remapping_info *entry; struct ptirq_remapping_info *entry;
@ -470,21 +470,19 @@ void ptirq_softirq(uint16_t pcpu_id)
if (entry->intr_type == PTDEV_INTR_INTX) { if (entry->intr_type == PTDEV_INTR_INTX) {
ptirq_handle_intx(vm, entry); ptirq_handle_intx(vm, entry);
} else { } else {
if (msi != NULL) {
/* TODO: msi destmode check required */ /* TODO: msi destmode check required */
(void)vlapic_intr_msi(vm, (void)vlapic_intr_msi(vm, msi->vmsi_addr, msi->vmsi_data);
msi->vmsi_addr, dev_dbg(ACRN_DBG_PTIRQ, "dev-assign: irq=0x%x MSI VR: 0x%x-0x%x",
msi->vmsi_data);
dev_dbg(ACRN_DBG_PTIRQ,
"dev-assign: irq=0x%x MSI VR: 0x%x-0x%x",
entry->allocated_pirq, entry->allocated_pirq,
msi->vmsi_data & 0xFFU, msi->vmsi_data & 0xFFU,
irq_to_vector(entry->allocated_pirq)); irq_to_vector(entry->allocated_pirq));
dev_dbg(ACRN_DBG_PTIRQ, dev_dbg(ACRN_DBG_PTIRQ, " vmsi_addr: 0x%llx vmsi_data: 0x%x",
" vmsi_addr: 0x%llx vmsi_data: 0x%x",
msi->vmsi_addr, msi->vmsi_addr,
msi->vmsi_data); msi->vmsi_data);
} }
} }
}
} }
void ptirq_intx_ack(struct acrn_vm *vm, uint8_t virt_pin, void ptirq_intx_ack(struct acrn_vm *vm, uint8_t virt_pin,
@ -511,6 +509,7 @@ void ptirq_intx_ack(struct acrn_vm *vm, uint8_t virt_pin,
break; break;
case PTDEV_VPIN_PIC: case PTDEV_VPIN_PIC:
vpic_set_irq(vm, virt_pin, GSI_SET_LOW); vpic_set_irq(vm, virt_pin, GSI_SET_LOW);
break;
default: default:
/* /*
* In this switch statement, vpin_src shall either be * In this switch statement, vpin_src shall either be