github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-09-29 04:25:57 +00:00
Code Issues Projects Releases Wiki Activity

hv: move error message logging into gpa copy APIs

Browse Source 
In this way, the code looks simpler and line of code is reduced.

Tracked-On: #3854
Signed-off-by: Zide Chen <zide.chen@intel.com>
This commit is contained in:
Zide Chen
2020-03-16 14:26:11 -07:00
committed by wenlingz
parent 37291fa890
commit eef3b51eda
4 changed files with 19 additions and 52 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
hypervisor/debug/hypercall.c
View File

@@ -82,7 +82,6 @@ static int32_t hcall_setup_sbuf(struct acrn_vm *vm, uint64_t param)
uint64_t *hva;
if (copy_from_gpa(vm, &ssp, param, sizeof(ssp)) != 0) {
pr_err("%s: Unable copy param to vm\n", __func__);
return -1;
}
@@ -110,18 +109,12 @@ static int32_t hcall_setup_hv_npk_log(struct acrn_vm *vm, uint64_t param)
struct hv_npk_log_param npk_param;
if (copy_from_gpa(vm, &npk_param, param, sizeof(npk_param)) != 0) {
pr_err("%s: Unable copy param from vm\n", __func__);
return -1;
}
npk_log_setup(&npk_param);
if (copy_to_gpa(vm, &npk_param, param, sizeof(npk_param)) != 0) {
pr_err("%s: Unable copy param to vm\n", __func__);
return -1;
}
return 0;
return copy_to_gpa(vm, &npk_param, param, sizeof(npk_param));
}
/**
@@ -138,18 +131,12 @@ static int32_t hcall_setup_hv_npk_log(struct acrn_vm *vm, uint64_t param)
*/
static int32_t hcall_get_hw_info(struct acrn_vm *vm, uint64_t param)
{
int32_t ret = 0;
struct acrn_hw_info hw_info;
(void)memset((void *)&hw_info, 0U, sizeof(hw_info));
hw_info.cpu_num = get_pcpu_nums();
ret = copy_to_gpa(vm, &hw_info, param, sizeof(hw_info));
if (ret != 0) {
pr_err("%s: Unable to copy param to vm", __func__);
}
return ret;
return copy_to_gpa(vm, &hw_info, param, sizeof(hw_info));
}
/**