github/acrn-hypervisor
1
0
Fork 0
mirror of https://github.com/projectacrn/acrn-hypervisor.git synced 2025-06-18 11:47:30 +00:00
Code Issues Projects Releases Wiki Activity

build fix: fix build issue with latest gcc for blkrescan

Browse Source 
With latest gcc version 9.1.1 20190506 from Clear Linux, we hit
following build issue in blkrescan code:
In function ‘strncpy’,
    inlined from ‘blkrescan_vm’ at acrn_vm_ops.c:468:2:
/usr/include/bits/string_fortified.h:106:10: error: \
‘__builtin___strncpy_chk’ specified bound depends on the length \
of the source argument [-Werror=stringop-overflow=]

When calling strncpy, the size n should be set to max dest size
instead of src size.

Tracked-On: #3096
Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
Acked-by: Yan, Like <like.yan@intel.com>
This commit is contained in:
Yin Fengwei 2019-05-10 10:25:50 +08:00 committed by wenlingz
parent c7da3976b7
commit eff44fb056
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/acrn-manager/acrn_vm_ops.c
View File

@ -465,7 +465,8 @@ int blkrescan_vm(const char *vmname, char *devargs)
req.magic = MNGR_MSG_MAGIC;
req.msgid = DM_BLKRESCAN;
req.timestamp = time(NULL);
strncpy(req.data.devargs, devargs, strlen(devargs)+1);
strncpy(req.data.devargs, devargs, PARAM_LEN - 1);
req.data.devargs[PARAM_LEN - 1] = '\0';
send_msg(vmname, &req, &ack);