mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2025-04-29 20:24:00 +00:00
The coding guideline rules C-TY-27 and C-TY-28, combined, requires that assignment and arithmetic operations shall be applied only on operands of the same kind. This patch either adds explicit type casts or adjust types of variables to align the types of operands. The only semantic change introduced by this patch is the promotion of the second argument of set_vmcs_bit() and clear_vmcs_bit() to uint64_t (formerly uint32_t). This avoids clear_vmcs_bit() to accidentally clears the upper 32 bits of the requested VMCS field. Other than that, this patch has no semantic change. Specifically this patch is not meant to fix buggy narrowing operations, only to make these operations explicit. Tracked-On: #6776 Signed-off-by: Junjie Mao <junjie.mao@intel.com> Acked-by: Eddie Dong <eddie.dong@intel.com>
214 lines
6.5 KiB
C
214 lines
6.5 KiB
C
/*
|
|
* Copyright (c) 2011 NetApp, Inc.
|
|
* Copyright (c) 2018 Intel Corporation
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY NETAPP, INC ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL NETAPP, INC OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
#include <asm/guest/vm.h>
|
|
#include "vpci_priv.h"
|
|
#include <asm/guest/ept.h>
|
|
#include <asm/guest/virq.h>
|
|
#include <logmsg.h>
|
|
#include <hash.h>
|
|
|
|
/**
|
|
* @pre vdev != NULL
|
|
*/
|
|
uint32_t pci_vdev_read_vcfg(const struct pci_vdev *vdev, uint32_t offset, uint32_t bytes)
|
|
{
|
|
uint32_t val;
|
|
|
|
switch (bytes) {
|
|
case 1U:
|
|
val = vdev->cfgdata.data_8[offset];
|
|
break;
|
|
case 2U:
|
|
val = vdev->cfgdata.data_16[offset >> 1U];
|
|
break;
|
|
default:
|
|
val = vdev->cfgdata.data_32[offset >> 2U];
|
|
break;
|
|
}
|
|
|
|
return val;
|
|
}
|
|
|
|
/**
|
|
* @pre vdev != NULL
|
|
*/
|
|
void pci_vdev_write_vcfg(struct pci_vdev *vdev, uint32_t offset, uint32_t bytes, uint32_t val)
|
|
{
|
|
switch (bytes) {
|
|
case 1U:
|
|
vdev->cfgdata.data_8[offset] = (uint8_t)val;
|
|
break;
|
|
case 2U:
|
|
vdev->cfgdata.data_16[offset >> 1U] = (uint16_t)val;
|
|
break;
|
|
default:
|
|
vdev->cfgdata.data_32[offset >> 2U] = val;
|
|
break;
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @pre vpci != NULL
|
|
* @pre vpci->pci_vdev_cnt <= CONFIG_MAX_PCI_DEV_NUM
|
|
*/
|
|
struct pci_vdev *pci_find_vdev(struct acrn_vpci *vpci, union pci_bdf vbdf)
|
|
{
|
|
struct pci_vdev *vdev = NULL, *tmp;
|
|
struct hlist_node *n;
|
|
|
|
hlist_for_each(n, &vpci->vdevs_hlist_heads[hash64(vbdf.value, VDEV_LIST_HASHBITS)]) {
|
|
tmp = hlist_entry(n, struct pci_vdev, link);
|
|
if (bdf_is_equal(vbdf, tmp->bdf)) {
|
|
vdev = tmp;
|
|
break;
|
|
}
|
|
}
|
|
|
|
return vdev;
|
|
}
|
|
|
|
static bool is_pci_mem_bar_base_valid(struct acrn_vm *vm, uint64_t base)
|
|
{
|
|
struct acrn_vpci *vpci = &vm->vpci;
|
|
struct pci_mmio_res *res = (base < (1UL << 32UL)) ? &(vpci->res32): &(vpci->res64);
|
|
|
|
return ((base >= res->start) && (base <= res->end));
|
|
}
|
|
|
|
static void pci_vdev_update_vbar_base(struct pci_vdev *vdev, uint32_t idx)
|
|
{
|
|
struct pci_vbar *vbar;
|
|
uint64_t base = 0UL;
|
|
uint32_t lo, hi, offset;
|
|
struct pci_mmio_res *res;
|
|
|
|
vbar = &vdev->vbars[idx];
|
|
offset = pci_bar_offset(idx);
|
|
lo = pci_vdev_read_vcfg(vdev, offset, 4U);
|
|
if ((!is_pci_reserved_bar(vbar)) && (lo != (vbar->mask | vbar->bar_type.bits))) {
|
|
base = lo & vbar->mask;
|
|
|
|
if (is_pci_mem64lo_bar(vbar)) {
|
|
vbar = &vdev->vbars[idx + 1U];
|
|
hi = pci_vdev_read_vcfg(vdev, (offset + 4U), 4U);
|
|
if (hi != vbar->mask) {
|
|
base |= ((uint64_t)hi << 32U);
|
|
} else {
|
|
base = 0UL;
|
|
}
|
|
}
|
|
|
|
if (is_pci_io_bar(vbar)) {
|
|
/* Because guest driver may write to upper 16-bits of PIO BAR and expect that should have no effect,
|
|
* SO PIO BAR base may bigger than 0xffff after calculation, should mask the upper 16-bits.
|
|
*/
|
|
base &= 0xffffUL;
|
|
}
|
|
}
|
|
|
|
if (base != 0UL) {
|
|
if (is_pci_io_bar(vbar)) {
|
|
/*
|
|
* ACRN-DM and acrn-config should ensure the identical mapping of PIO bar of pass-thru devs.
|
|
* Currently, we don't support the reprogram of PIO bar of pass-thru devs,
|
|
* If guest tries to reprogram, hv will inject #GP to guest.
|
|
*/
|
|
if ((vdev->pdev != NULL) && ((lo & PCI_BASE_ADDRESS_IO_MASK) != (uint32_t)vbar->base_hpa)) {
|
|
struct acrn_vcpu *vcpu = vcpu_from_pid(vpci2vm(vdev->vpci), get_pcpu_id());
|
|
if (vcpu != NULL) {
|
|
vcpu_inject_gp(vcpu, 0U);
|
|
}
|
|
pr_err("%s, PCI:%02x:%02x.%x PIO BAR%d couldn't be reprogramed, "
|
|
"the valid value is 0x%lx, but the actual value is 0x%lx",
|
|
__func__, vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx,
|
|
vdev->vbars[idx].base_hpa, lo & PCI_BASE_ADDRESS_IO_MASK);
|
|
base = 0UL;
|
|
}
|
|
} else if ((!is_pci_mem_bar_base_valid(vpci2vm(vdev->vpci), base))
|
|
|| (!mem_aligned_check(base, vdev->vbars[idx].size))) {
|
|
res = (base < (1UL << 32UL)) ? &(vdev->vpci->res32): &(vdev->vpci->res64);
|
|
/* VM tries to reprogram vbar address out of pci mmio bar window, it can be caused by:
|
|
* 1. For Service VM, <board>.xml is misaligned with the actual native platform, and we get wrong mmio window.
|
|
* 2. Malicious operation from VM, it tries to reprogram vbar address out of pci mmio bar window
|
|
*/
|
|
pr_err("%s reprogram PCI:%02x:%02x.%x BAR%d to addr:0x%lx,"
|
|
" which is out of mmio window[0x%lx - 0x%lx] or not aligned with size: 0x%lx",
|
|
__func__, vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx, base, res->start,
|
|
res->end, vdev->vbars[idx].size);
|
|
}
|
|
}
|
|
|
|
vdev->vbars[idx].base_gpa = base;
|
|
}
|
|
|
|
int32_t check_pt_dev_pio_bars(struct pci_vdev *vdev)
|
|
{
|
|
int32_t ret = 0;
|
|
uint32_t idx;
|
|
|
|
if (vdev->pdev != NULL) {
|
|
for (idx = 0U; idx < vdev->nr_bars; idx++) {
|
|
if ((is_pci_io_bar(&vdev->vbars[idx])) && (vdev->vbars[idx].base_gpa != vdev->vbars[idx].base_hpa)) {
|
|
ret = -EIO;
|
|
pr_err("%s, PCI:%02x:%02x.%x PIO BAR%d isn't identical mapping, "
|
|
"host start addr is 0x%lx, while guest start addr is 0x%lx",
|
|
__func__, vdev->bdf.bits.b, vdev->bdf.bits.d, vdev->bdf.bits.f, idx,
|
|
vdev->vbars[idx].base_hpa, vdev->vbars[idx].base_gpa);
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
void pci_vdev_write_vbar(struct pci_vdev *vdev, uint32_t idx, uint32_t val)
|
|
{
|
|
struct pci_vbar *vbar;
|
|
uint32_t bar, offset;
|
|
uint32_t update_idx = idx;
|
|
|
|
vbar = &vdev->vbars[idx];
|
|
bar = val & vbar->mask;
|
|
if (vbar->is_mem64hi) {
|
|
update_idx -= 1U;
|
|
} else {
|
|
if (is_pci_io_bar(vbar)) {
|
|
bar |= (vbar->bar_type.bits & (~PCI_BASE_ADDRESS_IO_MASK));
|
|
} else {
|
|
bar |= (vbar->bar_type.bits & (~PCI_BASE_ADDRESS_MEM_MASK));
|
|
}
|
|
}
|
|
offset = pci_bar_offset(idx);
|
|
pci_vdev_write_vcfg(vdev, offset, 4U, bar);
|
|
|
|
pci_vdev_update_vbar_base(vdev, update_idx);
|
|
}
|