mirror of
https://github.com/projectacrn/acrn-hypervisor.git
synced 2025-05-03 05:56:57 +00:00
3027bfab10
In the hypervisor, physical cpu id is defined as "int" or "uint32_t"
type in the hypervisor. So there are some sign conversion issues
about physical cpu id (pcpu_id) reported by static analysis tool.
Sign conversion violates the rules of MISRA C:2012.
In this patch, define physical cpu id as "uint16_t" type for all
modules in the hypervisor and change related codes. The valid
range of pcpu_id is 0~65534, INVALID_PCPU_ID is defined to the
invalid pcpu_id for error detection, BROADCAST_PCPU_ID is
broadcast pcpu_id used to notify all valid pcpu.
The type of pcpu_id in the struct vcpu and vcpu_id is "int" type,
this will be fixed in another patch.
V1-->V2:
* Change the type of pcpu_id from uint32_t to uint16_t;
* Define INVALID_PCPU_ID for error detection;
* Define BROADCAST_PCPU_ID to notify all valid pcpu.
V2-->V3:
* Update comments for INVALID_PCPU_ID and BROADCAST_PCPU_ID;
* Update addtional pcpu_id;
* Convert hexadecimals to unsigned to meet the type of pcpu_id;
* Clean up for MIN_PCPU_ID and MAX_PCPU_ID, they will be
defined by configuration.
Note: fix bug in the init_lapic(), the pcpu_id shall be less than 8,
this is constraint by implement in the init_lapic().
Signed-off-by: Xiangyang Wu <xiangyang.wu@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
90 lines
1.6 KiB
C
90 lines
1.6 KiB
C
/*
|
|
* Copyright (C) 2018 Intel Corporation. All rights reserved.
|
|
*
|
|
* SPDX-License-Identifier: BSD-3-Clause
|
|
*/
|
|
|
|
#include <hypervisor.h>
|
|
|
|
void disable_softirq(uint16_t cpu_id)
|
|
{
|
|
bitmap_clear(SOFTIRQ_ATOMIC, &per_cpu(softirq_pending, cpu_id));
|
|
}
|
|
|
|
void enable_softirq(uint16_t cpu_id)
|
|
{
|
|
bitmap_set(SOFTIRQ_ATOMIC, &per_cpu(softirq_pending, cpu_id));
|
|
}
|
|
|
|
void init_softirq(void)
|
|
{
|
|
uint16_t cpu_id;
|
|
|
|
for (cpu_id = 0; cpu_id < phy_cpu_num; cpu_id++) {
|
|
per_cpu(softirq_pending, cpu_id) = 0;
|
|
bitmap_set(SOFTIRQ_ATOMIC, &per_cpu(softirq_pending, cpu_id));
|
|
}
|
|
}
|
|
|
|
void raise_softirq(int softirq_id)
|
|
{
|
|
uint16_t cpu_id = get_cpu_id();
|
|
uint64_t *bitmap = &per_cpu(softirq_pending, cpu_id);
|
|
|
|
if (cpu_id >= phy_cpu_num)
|
|
return;
|
|
|
|
bitmap_set(softirq_id, bitmap);
|
|
}
|
|
|
|
void exec_softirq(void)
|
|
{
|
|
uint16_t cpu_id = get_cpu_id();
|
|
volatile uint64_t *bitmap = &per_cpu(softirq_pending, cpu_id);
|
|
|
|
int softirq_id;
|
|
|
|
if (cpu_id >= phy_cpu_num)
|
|
return;
|
|
|
|
if (((*bitmap) & SOFTIRQ_MASK) == 0UL)
|
|
return;
|
|
|
|
/* Disable softirq
|
|
* SOFTIRQ_ATOMIC bit = 0 means softirq already in execution
|
|
*/
|
|
if (!bitmap_test_and_clear(SOFTIRQ_ATOMIC, bitmap))
|
|
return;
|
|
|
|
again:
|
|
CPU_IRQ_ENABLE();
|
|
|
|
while (1) {
|
|
softirq_id = ffs64(*bitmap);
|
|
if ((softirq_id < 0) || (softirq_id >= SOFTIRQ_MAX))
|
|
break;
|
|
|
|
bitmap_clear(softirq_id, bitmap);
|
|
|
|
switch (softirq_id) {
|
|
case SOFTIRQ_TIMER:
|
|
timer_softirq(cpu_id);
|
|
break;
|
|
case SOFTIRQ_DEV_ASSIGN:
|
|
ptdev_softirq(cpu_id);
|
|
break;
|
|
default:
|
|
break;
|
|
|
|
}
|
|
}
|
|
|
|
CPU_IRQ_DISABLE();
|
|
|
|
if (((*bitmap) & SOFTIRQ_MASK) != 0U)
|
|
goto again;
|
|
|
|
enable_softirq(cpu_id);
|
|
}
|
|
|